Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move helm chart version to strict SemVer 2 #1888

Open
ed-boykin opened this issue May 13, 2024 · 6 comments
Open

Move helm chart version to strict SemVer 2 #1888

ed-boykin opened this issue May 13, 2024 · 6 comments

Comments

@ed-boykin
Copy link

Helm v3 requires strict SemVer2 versioning. In particular OCI repositories will not support the current versioning scheme used by the azurefile-csi-driver. ex: v1.29.5.

Security requirements may require cached pull-through on charts, or for 3rd party charts to be stored in private OCI repos.

Would like to see the Chart.yaml version field use proper SemVer2 by removing the 'v', ex: version: 1.29.5 instead of version: v.1.29.5

Helm Chart versioning
SemVer2

@andyzhangx
Copy link
Member

@ed-boykin
there are appVersion and version fields, which one should not have v? and for compatibility concern, we won't do that for existing v1.30 or earlier versions, we could fix is in v1.31 or later version.

appVersion: v1.30.2
description: Azure File Container Storage Interface (CSI) Storage Plugin
name: azurefile-csi-driver
version: v1.30.2

@ed-boykin
Copy link
Author

The 'version' field is the important one. This is used by helm tools especially when packaging the chart and when pushing to an OCI repo.
Charts and Versioning

Understood about not fixing prior versions.

@andyzhangx
Copy link
Member

we could only fix this from 1.31

@ed-boykin
Copy link
Author

That would be ok and VERY helpful. Thanks.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 17, 2024
@ed-boykin
Copy link
Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants