-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version popout to "Packaged Distributions" table #3842
base: master
Are you sure you want to change the base?
Add version popout to "Packaged Distributions" table #3842
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jbottum @andreyvelich @kimwnasptd @terrytangyuan @ederign please take a look at this important style update to the "Packaged Distributions" table. It should help avoid confusion with new users about which distributions are currently supported. |
The screenshots look good to me. |
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
27ec59f
to
baecd28
Compare
Since this impacts how distributions are promoted, my suggestion is that it would be good if a majority of the distribution owners approved this i.e. we need 6 distributions to provide a +1 or lgtm |
/cc @kubeflow/kubeflow-steering-committee |
@terrytangyuan: GitHub didn't allow me to request PR reviews from the following users: kubeflow/kubeflow-steering-committee. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR improves the "Packaged Distributions" table by making it clearer how old/new each Kubeflow Version is. Right now, it's very confusing to new users, as they might not know that Kubeflow 1.7 is actually very old (released in March 2023), so they might start the process of adopting a long-abandoned distribution.
The key changes this PR makes are:
Please note, all of the styling is automatic:
content/en/docs/started/installing-kubeflow/get_new_releases.sh
to cache that version's release date into thecontent/en/docs/started/installing-kubeflow/release-info
folder of JSON (the build will fail to remind you if you try referencing a version which it does not know about)Screenshots
OLD
NEW
Table Overview
On-Hover ("Latest Version")
On-Hover ("1 from Latest Version")
On-Hover ("2 from Latest Version")
On-Hover ("3+ from Latest Version")