Make basic community membership guidelines clearer #3827

anishasthana · 2024-07-24T21:36:58Z

This PR adds guidelines around the kubeflow community membership.

This set of guidelines is heavily inspired by the Kubernetes guidelines at https://github.com/kubernetes/community/blob/master/community-membership.md?plain=1#community-membership

cc @kubeflow/kubeflow-steering-committee

google-oss-prow · 2024-07-24T21:37:04Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign terrytangyuan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/en/docs/about/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow · 2024-07-24T21:37:09Z

Hi @anishasthana. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hbelmiro

/lgtm
/ok-to-test

cc @terrytangyuan

google-oss-prow · 2024-08-07T01:20:43Z

New changes are detected. LGTM label has been removed.

Signed-off-by: Anish Asthana <[email protected]>

content/en/docs/about/membership.md

terrytangyuan

This would be a great improvements over the current process. Thanks!

One thing that is being discussed is how to encourage non-code contributions. This may not be something this PR covers and can be future improvements IMO. I'll share with the outreach team to help review.

content/en/docs/about/membership.md

andreyvelich · 2024-09-23T15:55:41Z

@anishasthana Did you address all of the comments from this PR: kubeflow/community#737?
Is this PR ready for the second review ?

/assign @kubeflow/wg-training-leads @kubeflow/wg-automl-leads @kubeflow/wg-notebooks-leads @kubeflow/wg-pipeline-leads @kubeflow/wg-data-leads

anishasthana · 2024-09-23T16:30:19Z

@andreyvelich this PR is ready for second review

tarilabs

Thanks @anishasthana I believe a clearer guideline helps a lot !

Wdyt about the suggestions below, based on previously received feedback.
Thank you for your consideration in any case.

content/en/docs/about/membership.md

terrytangyuan · 2024-09-24T14:49:17Z

My only comment is unaddressed #3827 (comment) but otherwise LGTM. Thank you for improving the process!

andreyvelich

Thank you so much for driving this @anishasthana!
I left my comments.
Also, should we also add the section for WG Leads and WG Chairs ?
I think, it would be nice to explain how to become WG members in this doc as well.

andreyvelich · 2024-09-26T13:48:29Z

content/en/docs/about/contributing.md


 ### Follow the code of conduct

 Please make sure to read and observe our [Code of Conduct](https://github.com/kubeflow/community/blob/master/CODE_OF_CONDUCT.md)
 and [inclusivity document](https://github.com/kubeflow/community/blob/master/INCLUSIVITY.md).

-## Joining the community
+## Membership


Can we link this doc from the Community doc ? I think, it would be nice to reference it from there
https://deploy-preview-3827--competent-brattain-de2d6d.netlify.app/docs/about/community/

andreyvelich · 2024-09-26T13:49:58Z

content/en/docs/about/contributing.md


-Follow these instructions if you want to:
+Details about the different types of Kubeflow members as well as membership criteria can be found at [Community Membership](/docs/about/membership/)


the different types of Kubeflow members

Is that statement correct ?
E.g. currently, we have information about Kubeflow WGs here: https://deploy-preview-3827--competent-brattain-de2d6d.netlify.app/docs/about/community/#kubeflow-working-groups

Maybe we should move this part into Community Membership doc, WDYT @anishasthana @terrytangyuan @kubeflow/kubeflow-steering-committee @StefanoFioravanzo @hbelmiro ?

Is that statement correct ?

I think it is -- the changes in the other file are introducing the contents right?

This sentence seems correct to me

content/en/docs/about/contributing.md

andreyvelich · 2024-09-26T13:56:21Z

content/en/docs/about/membership.md

+++
+
+
+**Note:** This document is a work in progress


If you want, you can try to use Hugo rendered Notes, like here: https://github.com/kubernetes/website/blob/main/content/en/docs/concepts/workloads/controllers/job.md?plain=1#L309-L315.
They look pretty nice on the website: https://kubernetes.io/docs/concepts/workloads/controllers/job/#handling-pod-and-container-failures:~:text=Note%3A,they%20are%20detected.

andreyvelich · 2024-09-26T14:34:39Z

content/en/docs/about/membership.md

+
+The following apply to the part of codebase for which one would be an approver in an [OWNERS] file (for repos using the bot).
+
+- Reviewer of the codebase for at least 3 months


Should also approver be the reviewer before ?

andreyvelich · 2024-09-26T14:38:14Z

content/en/docs/about/membership.md

+- Reviewer of the codebase for at least 3 months
+- Primary reviewer for at least 10 substantial PRs to the codebase
+- Reviewed or merged at least 30 PRs to the codebase
+- Nominated by a WG Lead, Chair or owner


I would only leave WG Lead or Chair.

I was thinking of situations where a root approver may nominate an approver for a subdirectory or similar. WG Leads and Chairs aren't necessarily involved with the day-to-day of every repository right?

content/en/docs/about/membership.md

andreyvelich · 2024-09-26T14:39:23Z

content/en/docs/about/membership.md

+- Reviewed or merged at least 30 PRs to the codebase
+- Nominated by a WG Lead, Chair or owner
+  - With no objections from other Leads or owners
+  - Done through PR to update the top-level OWNERS file


Should this be top-level OWNER ?

andreyvelich · 2024-09-26T14:41:06Z

content/en/docs/about/membership.md

+### How inactivity is measured
+
+Inactive members are defined as members of one of the Kubeflow Organizations
+with **no** contributions across any organization within 12 months.


Maybe we should explicitly say ""with no technical and non-technical contributions""

Isn't that the same as "with no contributions"?

andreyvelich · 2024-09-26T14:43:42Z

/assign @StefanoFioravanzo @kubeflow/kubeflow-steering-committee @franciscojavierarceo

andreyvelich · 2024-09-26T14:47:28Z

cc @akgraner

Signed-off-by: Anish Asthana <[email protected]>

google-oss-prow bot requested a review from 8bitmp3 July 24, 2024 21:37

google-oss-prow bot requested a review from johnugeorge July 24, 2024 21:37

google-oss-prow bot added the needs-ok-to-test label Jul 24, 2024

google-oss-prow bot added the size/S label Jul 24, 2024

anishasthana mentioned this pull request Jul 24, 2024

Add anishasthana to kubeflow org kubeflow/internal-acls#690

Merged

hbelmiro reviewed Jul 25, 2024

View reviewed changes

google-oss-prow bot added ok-to-test and removed needs-ok-to-test labels Jul 25, 2024

google-oss-prow bot assigned hbelmiro Jul 25, 2024

google-oss-prow bot added the lgtm label Jul 25, 2024

google-oss-prow bot removed the lgtm label Aug 7, 2024

google-oss-prow bot added size/L and removed size/S labels Aug 7, 2024

anishasthana mentioned this pull request Aug 7, 2024

Minor cleanup on contributing guide kubeflow/community#737

Open

anishasthana changed the title ~~Make basic community membership guidelines clearer~~ WIP: Make basic community membership guidelines clearer Aug 7, 2024

google-oss-prow bot added the do-not-merge/work-in-progress label Aug 7, 2024

anishasthana force-pushed the update_community_membership_guidelines branch from 2931fd6 to 4b3de1b Compare August 7, 2024 01:29

Make basic community membership guidelines clearer

8d2f5d6

Signed-off-by: Anish Asthana <[email protected]>

anishasthana force-pushed the update_community_membership_guidelines branch 2 times, most recently from b17b1ac to b0d245b Compare August 7, 2024 14:30

hbelmiro reviewed Aug 7, 2024

View reviewed changes

content/en/docs/about/membership.md Outdated Show resolved Hide resolved

anishasthana force-pushed the update_community_membership_guidelines branch 2 times, most recently from 908075a to 90c127a Compare August 7, 2024 14:35

terrytangyuan reviewed Aug 19, 2024

View reviewed changes

content/en/docs/about/membership.md Show resolved Hide resolved

tarilabs reviewed Sep 24, 2024

View reviewed changes

content/en/docs/about/membership.md Outdated Show resolved Hide resolved

content/en/docs/about/membership.md Show resolved Hide resolved

terrytangyuan changed the title ~~WIP: Make basic community membership guidelines clearer~~ Make basic community membership guidelines clearer Sep 24, 2024

google-oss-prow bot removed the do-not-merge/work-in-progress label Sep 24, 2024

andreyvelich reviewed Sep 26, 2024

View reviewed changes

anishasthana force-pushed the update_community_membership_guidelines branch 4 times, most recently from 4a783b4 to 7bd7793 Compare September 27, 2024 18:38

Add Membership Guidelines

80c5677

Signed-off-by: Anish Asthana <[email protected]>

anishasthana force-pushed the update_community_membership_guidelines branch from 7bd7793 to 80c5677 Compare September 27, 2024 18:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make basic community membership guidelines clearer #3827

Make basic community membership guidelines clearer #3827

anishasthana commented Jul 24, 2024 •

edited

Loading

google-oss-prow bot commented Jul 24, 2024

google-oss-prow bot commented Jul 24, 2024

hbelmiro left a comment

google-oss-prow bot commented Aug 7, 2024

terrytangyuan left a comment

andreyvelich commented Sep 23, 2024

anishasthana commented Sep 23, 2024

tarilabs left a comment

terrytangyuan commented Sep 24, 2024

andreyvelich left a comment

andreyvelich Sep 26, 2024

anishasthana Sep 27, 2024

andreyvelich Sep 26, 2024

andreyvelich Sep 26, 2024

anishasthana Sep 27, 2024

terrytangyuan Sep 28, 2024

andreyvelich Sep 26, 2024

andreyvelich Sep 26, 2024

andreyvelich Sep 26, 2024

anishasthana Sep 27, 2024

andreyvelich Sep 26, 2024

andreyvelich Sep 26, 2024

terrytangyuan Sep 28, 2024

andreyvelich commented Sep 26, 2024

andreyvelich commented Sep 26, 2024


		Follow these instructions if you want to:
		Details about the different types of Kubeflow members as well as membership criteria can be found at [Community Membership](/docs/about/membership/)


		The following apply to the part of codebase for which one would be an approver in an [OWNERS] file (for repos using the bot).

		- Reviewer of the codebase for at least 3 months

Make basic community membership guidelines clearer #3827

Are you sure you want to change the base?

Make basic community membership guidelines clearer #3827

Conversation

anishasthana commented Jul 24, 2024 • edited Loading

google-oss-prow bot commented Jul 24, 2024

google-oss-prow bot commented Jul 24, 2024

hbelmiro left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Aug 7, 2024

terrytangyuan left a comment

Choose a reason for hiding this comment

andreyvelich commented Sep 23, 2024

anishasthana commented Sep 23, 2024

tarilabs left a comment

Choose a reason for hiding this comment

terrytangyuan commented Sep 24, 2024

andreyvelich left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andreyvelich commented Sep 26, 2024

andreyvelich commented Sep 26, 2024

anishasthana commented Jul 24, 2024 •

edited

Loading