Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

本番環境でもstrictModeがonになっている #32

Open
ktaroabobon opened this issue Sep 29, 2022 · 5 comments
Open

本番環境でもstrictModeがonになっている #32

ktaroabobon opened this issue Sep 29, 2022 · 5 comments

Comments

@ktaroabobon
Copy link
Owner

No description provided.

@ktaroabobon
Copy link
Owner Author

一旦strictModeを削除した

@ktaroabobon
Copy link
Owner Author

たぶんbuildの際のenvがdevになっている

@ktaroabobon
Copy link
Owner Author

ただ、開発環境でもuseEffectが2回呼ばれるのは困る

@ktaroabobon ktaroabobon mentioned this issue Oct 3, 2022
Closed
@ktaroabobon
Copy link
Owner Author

ktaroabobon commented Oct 3, 2022 •
edited
Loading

CDの際のbuildにおいて環境がdevに設定されて実行されている

ifcjs-react/.github/workflows/deploy.yaml

Lines 28 to 29 in 8d4516a

- name: Build
run: make build

ifcjs-react/Makefile

Lines 24 to 27 in 8d4516a

build: ENVIRONMENT=development
build: VITE_OPTS=
build:
yarn run vite build $(VITE_OPTS) -m $(ENVIRONMENT)

@ktaroabobon
Copy link
Owner Author 

make build ENVIRONMENT=production

みたいに書けばいけるかも？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ktaroabobon