Oauth proxy limit #324

fcami · 2023-02-02T10:42:30Z

Motivation

Modifications

--- a/config/internal/base/deployment.yaml.tmpl
+++ b/config/internal/base/deployment.yaml.tmpl
@@ -162,10 +162,10 @@ spec:
             failureThreshold: 3
           resources:
             limits:
-              cpu: 100m
+              cpu: 2
               memory: 256Mi
             requests:
-              cpu: 100m
+              cpu: 500m
               memory: 256Mi
           volumeMounts:
             - mountPath: /etc/tls/private

Result

Signed-off-by: Anish Asthana <[email protected]>

Modelmesh owners

…atahub-io#188)" This reverts commit 564e71b.

Revert "Fix etcd endpoints when etcd is in different namespace (opendatahub-io#188)"

This change will hide models behind proxy. Only tokens which have "get" access to services in the namespace the modelservingruntime is deployed in will be able to hit models. Signed-off-by: Anish Asthana <[email protected]>

Prototype for oauth config

Signed-off-by: Anish Asthana <[email protected]>

…ontroller Add odh model controller

Signed-off-by: Anish Asthana <[email protected]>

…h_manifest Allow ODH Model Controller to create cluster role bindings

Signed-off-by: Anish Asthana <[email protected]>

Add authentication images for ModelMesh

Adding ModelMesh Serving end to end tests

Update manifests' directory structure

Signed-off-by: Anish Asthana <[email protected]>

Add simple demo for modelmesh usage

Signed-off-by: Anish Asthana <[email protected]>

Wait for CRDS to be created in quickstart script

Removing Pipfile and Pipfile.lock references

Removing micropipenv install

Fix: Fix sed for kfdef URI / CI test failure

Signed-off-by: Anish Asthana <[email protected]>

Merge commit was created on November 8th, 2022. The reason we have elected to do this instead of a normal rebase is due to a merge commit having been created at some point in the past, which has made rebases impossible

…merge Upstream sync merge

…_edits Stop odh model controller from adding/removing namespace labels

Signed-off-by: Anish Asthana <[email protected]>

…e_updates Update images to latest tags

Add HumairAK to owners. Longer term we need to revisit the reviewers and approvers instead of having everyone able to approve PRs Signed-off-by: Anish Asthana <[email protected]>

Signed-off-by: Anish Asthana <[email protected]>

Update the annotations required for authentication and routes

Add Humair to OWNERS

Signed-off-by: Anish Asthana <[email protected]>

Stop workflows from triggering on PRs to main

[pull] main from kserve:main

Signed-off-by: Anish Asthana <[email protected]>

…agement Allow odh model controller to manage the storage config secret

Refer to opendatahub-io/odh-model-controller#12 Signed-off-by: Anish Asthana <[email protected]>

…el_controller Move model-controller back into dedicated repo

Signed-off-by: Humair Khan <[email protected]>

Have etcd service select only etcd pods.

Signed-off-by: Anish Asthana <[email protected]>

Update OWNERS to reflect new team structure

With a CPU limit of 100m, oauth-proxy seems unable to cope with the load associated with its own liveness probes, leading to the model mesh pods being restarted every so often once a certain number of routes (inference services) are created. Raise the CPU limit from 100m to 2. Raise the CPU request from 100m to 0.5. Related-to: opendatahub-io#62 Related-to: opendatahub-io#16 Signed-off-by: François Cami <[email protected]>

kserve-oss-bot · 2023-02-02T10:42:37Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fcami
To complete the pull request process, please assign njhill after the PR has been reviewed.
You can assign the PR to them by writing /assign @njhill in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fcami · 2023-02-02T10:43:17Z

Sorry, closing this one, will work through ODH first.

anishasthana and others added 30 commits August 30, 2022 14:53

Add ODH Owners

d6d8a0f

Signed-off-by: Anish Asthana <[email protected]>

Copy odh-manifests contents to this repository for development

d4e9b58

Signed-off-by: Anish Asthana <[email protected]>

Add kfdef for easy deployment of development artifacts

d719343

Signed-off-by: Anish Asthana <[email protected]>

Merge pull request opendatahub-io#1 from anishasthana/modelmesh_owners

973363f

Modelmesh owners

Revert "Fix etcd endpoints when etcd is in different namespace (opend…

2be8cc9

…atahub-io#188)" This reverts commit 564e71b.

Merge pull request opendatahub-io#2 from crobby/revertns

ec8b258

Revert "Fix etcd endpoints when etcd is in different namespace (opendatahub-io#188)"

Enable oauth proxy for models

0647b45

This change will hide models behind proxy. Only tokens which have "get" access to services in the namespace the modelservingruntime is deployed in will be able to hit models. Signed-off-by: Anish Asthana <[email protected]>

Merge pull request opendatahub-io#3 from anishasthana/add_oauth_config

6df3cbb

Prototype for oauth config

Migrade ODH Model Controller contents to this repository

2870660

Signed-off-by: Anish Asthana <[email protected]>

Update OWNERS

ee82e0c

Signed-off-by: Anish Asthana <[email protected]>

Merge pull request opendatahub-io#4 from anishasthana/add_odh_model_c…

49ceac7

…ontroller Add odh model controller

Allow ODH Model Controller to create cluster role bindings

49deee2

Signed-off-by: Anish Asthana <[email protected]>

Update Naming convention for auth delegation CRB to ensure uniqueness

67daff5

Signed-off-by: Anish Asthana <[email protected]>

Merge pull request opendatahub-io#5 from anishasthana/update_modelmes…

c82fbde

…h_manifest Allow ODH Model Controller to create cluster role bindings

Add support for oauth proxy to ModelMesh

6af13ca

Signed-off-by: Anish Asthana <[email protected]>

Merge pull request opendatahub-io#6 from anishasthana/update_manifests

7aef47b

Add authentication images for ModelMesh

Adding ModelMesh Serving end to end tests

8626508

Merge pull request opendatahub-io#7 from DharmitD/add-manifests

4c46e33

Adding ModelMesh Serving end to end tests

Update manifests' directory structure

aeb728f

Updating tests' kfdef to point to the updated path

7307bce

Updating the kfdef

985f2b8

Merge pull request opendatahub-io#8 from DharmitD/change-dir

13ef978

Update manifests' directory structure

Add simple demo for modelmesh usage

258ea53

Signed-off-by: Anish Asthana <[email protected]>

Merge pull request opendatahub-io#9 from anishasthana/add_quickstart

89b9d83

Add simple demo for modelmesh usage

Wait for CRDS to be created in quickstart script

b3b5923

Signed-off-by: Anish Asthana <[email protected]>

Merge pull request opendatahub-io#10 from anishasthana/wait_for_crds

294c0c4

Wait for CRDS to be created in quickstart script

Removing Pipefile and Pipefile.lock references

f7303e0

Merge pull request opendatahub-io#11 from DharmitD/change-dir

2dd9763

Removing Pipfile and Pipfile.lock references

Removing micropipenv install

d014de1

Merge pull request opendatahub-io#12 from DharmitD/change-dir

296d517

Removing micropipenv install

DharmitD and others added 25 commits October 31, 2022 17:42

Fix sed for kfdef uri

dde5b01

Merge pull request opendatahub-io#33 from DharmitD/ci-test

89f70ca

Fix: Fix sed for kfdef URI / CI test failure

Stop odh model controller from adding/removing namespace labels

8f52c6e

Signed-off-by: Anish Asthana <[email protected]>

Sync upstream kserve modelmesh-serving with odh modelmesh-serving

1d26860

Merge commit was created on November 8th, 2022. The reason we have elected to do this instead of a normal rebase is due to a merge commit having been created at some point in the past, which has made rebases impossible

Merge pull request opendatahub-io#43 from anishasthana/upstream_sync_…

c029a17

…merge Upstream sync merge

Merge pull request opendatahub-io#34 from anishasthana/stop_namespace…

e6eb0ac

…_edits Stop odh model controller from adding/removing namespace labels

Update images to latest tags

3204345

Signed-off-by: Anish Asthana <[email protected]>

Fix route generation logic to properly account for http routes

347d9bd

Signed-off-by: Anish Asthana <[email protected]>

Merge pull request opendatahub-io#45 from anishasthana/modelmesh_imag…

d51c9fc

…e_updates Update images to latest tags

Add Humair to OWNERS

3fa2b86

Add HumairAK to owners. Longer term we need to revisit the reviewers and approvers instead of having everyone able to approve PRs Signed-off-by: Anish Asthana <[email protected]>

Update the annotations required for authentication and routes

b540f4f

Signed-off-by: Anish Asthana <[email protected]>

Merge pull request opendatahub-io#49 from anishasthana/update_routes

83984ee

Update the annotations required for authentication and routes

Merge pull request opendatahub-io#46 from anishasthana/add_humair

c883641

Add Humair to OWNERS

Stop workflows from triggering on PRs to main

1c9458e

Signed-off-by: Anish Asthana <[email protected]>

Merge pull request opendatahub-io#50 from anishasthana/edit_workflows

e3d662c

Stop workflows from triggering on PRs to main

Merge pull request opendatahub-io#48 from kserve/main

65cddc3

[pull] main from kserve:main

Allow odh model controller to manage the storage config secret

d24a2e1

Signed-off-by: Anish Asthana <[email protected]>

Merge pull request opendatahub-io#51 from anishasthana/add_secret_man…

e6db6bb

…agement Allow odh model controller to manage the storage config secret

Move model-controller back into dedicated repo

7af3fd3

Refer to opendatahub-io/odh-model-controller#12 Signed-off-by: Anish Asthana <[email protected]>

Merge pull request opendatahub-io#53 from anishasthana/remove_odh_mod…

0ae9baf

…el_controller Move model-controller back into dedicated repo

Have etcd service select only etcd pods.

7e82040

Signed-off-by: Humair Khan <[email protected]>

Merge pull request opendatahub-io#54 from HumairAK/odh-etcd-mm-fix

f0920d9

Have etcd service select only etcd pods.

Update OWNERS to reflect new team structure

6fea188

Signed-off-by: Anish Asthana <[email protected]>

Merge pull request opendatahub-io#57 from anishasthana/update_owners

4a59d25

Update OWNERS to reflect new team structure

kserve-oss-bot requested a review from ckadner February 2, 2023 10:42

kserve-oss-bot requested a review from Tomcli February 2, 2023 10:42

fcami closed this Feb 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Oauth proxy limit #324

Oauth proxy limit #324

fcami commented Feb 2, 2023

kserve-oss-bot commented Feb 2, 2023

fcami commented Feb 2, 2023

Oauth proxy limit #324

Oauth proxy limit #324

Conversation

fcami commented Feb 2, 2023

Motivation

Modifications

Result

kserve-oss-bot commented Feb 2, 2023

fcami commented Feb 2, 2023