Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library forces users to create components as Pure Components #184

Open
kartiksharma1607 opened this issue Apr 21, 2020 · 0 comments
Open

Comments

@kartiksharma1607
Copy link

When using withStyles, library wraps React Component into a Pure Component.

https://github.com/kriasoft/isomorphic-style-loader/blob/master/src/withStyles.js#L17

This is done irrespective of user's preference. If user had created a normal React Component it should wrap it into a impure React Component. It should only wrap component into Pure Component if, user's component is itself a pure component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant