Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporating constants in the strings.xml file #49

Open
LuGO0 opened this issue Mar 8, 2020 · 4 comments
Open

Incorporating constants in the strings.xml file #49

LuGO0 opened this issue Mar 8, 2020 · 4 comments

Comments

@LuGO0
Copy link
Contributor

LuGO0 commented Mar 8, 2020

Is your feature request related to a problem? Please describe.
Refactoring the constants.java file

Describe the solution you'd like
Incorporating all the constants frim the constants.java file to the strings.xml file

@boring-cyborg
Copy link

boring-cyborg bot commented Mar 8, 2020

Thanks for opening your first issue here! Be sure to follow the issue template!

@krharsh17
Copy link
Owner

I'm not very convinced that we need to do this right now. I'll suggest that we wait until the end of the first or second phase to see how the Constants.java file grows, and if it is small enough, we'll go forward with this.

@LuGO0
Copy link
Contributor Author

LuGO0 commented Mar 8, 2020

Sure !!

@krharsh17
Copy link
Owner

@LuGO0 If you want to do a quick scan for any constants that might need to be shifted, please do so and share your findings here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants