Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC-681 does not support ERC-67 #79

Open
rmeissner opened this issue Dec 20, 2019 · 0 comments
Open

ERC-681 does not support ERC-67 #79

rmeissner opened this issue Dec 20, 2019 · 0 comments

Comments

@rmeissner
Copy link
Contributor

rmeissner commented Dec 20, 2019

As far as I understand https://eips.ethereum.org/EIPS/eip-831 EIP-681 should be backward compatible with ERC-67. Assuming the last state of ethereum/EIPs#67 then it is possible to add raw hex data for a transaction via the data param. This is not supported by the EIP-681 implementation of kethereum (everything is put into function params). I tried generating a ERC-67 uri with data and use it with Walleth, which did not work (the data is dropped)

Note: it might be that this should be discussed on some EIP thread, but I couldn't find a good one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant