Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink how we are adding new chains #102

Open
vikiival opened this issue Feb 16, 2023 · 2 comments
Open

Rethink how we are adding new chains #102

vikiival opened this issue Feb 16, 2023 · 2 comments

Comments

@vikiival
Copy link
Member

Currently to add new chain to KodaDot/nft-gallery

I need to:

  • extend prefixes in utils/config/types.ts
  • update utils/config/chain.config.ts
  • add new prefix in utils/queryPathResolver.ts
  • update utils/config/defineApolloConfig.ts
  • add to indexer constants in utils/constants.ts

Maybe it would be nice to rethink to new architecture along with multi-chain stuff ()
@vikiival vikiival changed the title Rethink how we are adding new Rethink how we are adding new chains Feb 16, 2023
@roiLeo
Copy link
Contributor

roiLeo commented Feb 16, 2023

@vikiival
Copy link
Member Author

@roiLeo yeah that would be the best option

https://github.com/kodadot/nft-gallery/tree/rmrk-two

alternatively I think to make a new package like @kodadot1/let or @kodadot1/const

where I would expose this stuff

@roiLeo roiLeo mentioned this issue Feb 24, 2023
Closed
@vikiival vikiival mentioned this issue Mar 3, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roiLeo @vikiival