Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offers: Cannot accept offer #11019

Open
JustLuuuu opened this issue Sep 20, 2024 · 5 comments
Open

Offers: Cannot accept offer #11019

JustLuuuu opened this issue Sep 20, 2024 · 5 comments
Labels
A-offer issues related to offers bug Something isn't working

Comments

@JustLuuuu
Copy link
Member

I created an offer for this NFT: https://kodadot.xyz/ahp/gallery/158-2407236917
From this wallet: 1NFfEH3yspdEgLnhZ5QWgb7B2z5LNCAE3HUo5nDxF5MqTcj
I accepted it from my other wallet: 14yzMSVPZVnaTx8Pk6vsr8Y5G1LPzSzvTrAwhasjidVtHbLq

After clicking on accept I got this error message. I have no idea what is the issue.
Screenshot 2024-09-20 at 11 32 05

Video

Screen.Recording.2024-09-20.at.11.33.02.mov
@JustLuuuu JustLuuuu added bug Something isn't working A-offer issues related to offers labels Sep 20, 2024
@Jarsen136
Copy link
Contributor

Jarsen136 commented Sep 20, 2024

I created an offer for this NFT: https://kodadot.xyz/ahp/gallery/158-2407236917 From this wallet: 1NFfEH3yspdEgLnhZ5QWgb7B2z5LNCAE3HUo5nDxF5MqTcj I accepted it from my other wallet: 14yzMSVPZVnaTx8Pk6vsr8Y5G1LPzSzvTrAwhasjidVtHbLq

After clicking on accept I got this error message. I have no idea what is the issue.

@JustLuuuu
This is due to insufficient balance. The offer price is 1 dot but the transferable balance in this account is 0.985 dot.

image

image

@JustLuuuu
Copy link
Member Author

@Jarsen136 how can I even create an offer on amount I dont have?

@Jarsen136
Copy link
Contributor

@Jarsen136 how can I even create an offer on amount I dont have?

When creating an offer, it will check the user's balance and make sure the user has enough tokens. However, creating offer does not reserve the amount of token. That means the user can still use or transfer the token afterwards.
Then it will happen, the balance is insufficient and the offer cannot be accepted.

@vikiival
Copy link
Member

vikiival commented Oct 9, 2024

prob fixed in #11035 ?

@Jarsen136
Copy link
Contributor

prob fixed in #11035 ?

In most cases, yes.
But it is still possible that if a user transfers out all the balance in their account, others will not be able to accept his offer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-offer issues related to offers bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants