Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Apply genart filter for Collections on koda.art #11045

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Sep 25, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
image image

Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 92bf18b
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/67015a86207c9f000884874d
😎 Deploy Preview https://deploy-preview-11045--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarcloud bot commented Oct 5, 2024

Comment on lines +1 to +6
// todo: const isArtGenDomain = ['koda.art'].includes(
// window.location.hostname,
// )
export const isArtGenDomain = location.hostname.startsWith('deploy-preview-') || ['koda.art', 'localhost'].includes(
window.location.hostname,
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark: todo before merged

@Jarsen136 Jarsen136 marked this pull request as ready for review October 5, 2024 15:28
@Jarsen136 Jarsen136 requested a review from a team as a code owner October 5, 2024 15:28
@Jarsen136 Jarsen136 requested review from vikiival and hassnian and removed request for a team October 5, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply genart filter for Collections on koda.art
2 participants