Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic cancel expired offer and return deposit #10963

Open
Jarsen136 opened this issue Sep 10, 2024 · 4 comments
Open

Automatic cancel expired offer and return deposit #10963

Jarsen136 opened this issue Sep 10, 2024 · 4 comments
Labels
A-offer issues related to offers A-worker our cf workers (minions)

Comments

@Jarsen136
Copy link
Contributor

          /// This function is used to cancel the specified swap offer created by the `caller` account. If
/// the swap offer's deadline has not yet passed, the `caller` must be the owner of the offered
/// item; otherwise, anyone can cancel an expired offer.
/// After canceling the swap offer, the function emits the `SwapCancelled` event.
///

In human lang:
If the offer is expired, we can setup a bot that will "clear" offers every N-hours

Originally posted by @vikiival in #10951 (comment)

@Jarsen136 Jarsen136 added A-offer issues related to offers A-worker our cf workers (minions) labels Sep 10, 2024
@vikiival
Copy link
Member

Which deposit? :D the offer nft?
That has to be burned by user, or you can reuse it for the next offer

@Jarsen136
Copy link
Contributor Author

Which deposit? :D the offer nft?

Yes, the price to mint the offer nft.

That has to be burned by user, or you can reuse it for the next offer

Will the mint price return to the user if he burns the nft? It looks like no when I test it.

@hassnian
Copy link
Contributor

hassnian commented Sep 24, 2024

@vikiival what was the reason for having it in the first place, reduce spam ?

maybe we can lower a bit, If the user does a lot offers it can become a substantial amount

@vikiival
Copy link
Member

reduce spam ?

Yup, you can write a script to "mint" all of them

maybe we can lower a bit

Screenshot 2024-09-24 at 14 15 44

currently is less than a quarter (25c) If you need some DOT/KSM for testing, please hit me up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-offer issues related to offers A-worker our cf workers (minions)
Projects
None yet
Development

No branches or pull requests

3 participants