Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 config: add configuration to create custom types #28

Closed
wants to merge 1 commit into from
Closed

🛠 config: add configuration to create custom types #28

wants to merge 1 commit into from

Conversation

mafzaldev
Copy link

fixes #25

CHANGELOG:

  • added minimalcommit.config.js
  • placed choices list to config file
  • added two custom types: 👷 chore and 🚀 deploy

@mafzaldev
Copy link
Author

@khattakdev
Can you please review my PR?

@khattakdev
Copy link
Owner

@mafzaldev The minimalcommit.config.js should be in the user directory, not in the npm package, similar to the way Prettier works.

Also - we are not adding more types to the default list. That will be up to the user to modify them.

@mafzaldev
Copy link
Author

What are you referring to "user directory"?

@khattakdev
Copy link
Owner

What are you referring to "user directory"?

The person who will be using this package via npm install... should be able to override the types in minimalcommit.config.js

@mafzaldev mafzaldev closed this by deleting the head repository Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Override default types
2 participants
@mafzaldev @khattakdev