Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Textual alternatives for unicode symbols missing #129

Open
KreerC opened this issue Mar 8, 2021 · 4 comments
Open

Accessibility: Textual alternatives for unicode symbols missing #129

KreerC opened this issue Mar 8, 2021 · 4 comments
Assignees

Comments

@KreerC
Copy link

KreerC commented Mar 8, 2021

The symbols used in the poll table do not have a suitable textual label for e.g. screen reader users. This could be done via aria-label or a an accessible popover containing a localized string like "yes", "no" and "maybe" as used in the code.

I'd appreciate a fix very much as this seems like a particularly easy thing to fix in poll.rb starting in line 285.

@kellerben
Copy link
Owner

you are right, this would be an easy fix. Wouldn't it be better to add this to the title in poll.rb line 290?

@kellerben kellerben self-assigned this Apr 26, 2021
@KreerC
Copy link
Author

KreerC commented Oct 27, 2021

I'm not familiar with the code per se, but I'd be happy to review a PR that implements a fix.

Also, for clarification, this should be considered a bug and receive a fix immediately because it renders the application unusable for a significant number of people.

@kellerben
Copy link
Owner

I added the aria-label to the input. In addition, I added the unicode symbol to the title.
Can you please review it here:
https://dudle.inf.tu-dresden.de/coffee/
the code is here:
https://github.com/kellerben/dudle/blob/master/poll.rb#L290-L291

@bkmgit
Copy link
Contributor

bkmgit commented Sep 12, 2022

https://wave.webaim.org indicates the labels appear, though adding language used for the page would likely also be helpful for screen readers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants