Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually Redect login fields after using Choose Custom Login Fields #2357

Open
ahouse73 opened this issue Oct 6, 2024 · 3 comments
Open
Labels

Comments

@ahouse73
Copy link

ahouse73 commented Oct 6, 2024

Expected Behavior

After selecting custom login fields, the fields should be automatically detected when visiting the website

Current Behavior

I Have to click Redetect login fields manually and then it gets detected

Possible Solution

Steps to Reproduce (for bugs)

  1. Visit https://sso.itmc.tu-dortmund.de/
  2. Choose Custom Login Fields (because the username input gets detected as TOTP field) and choose the username as username and password as password
  3. refresh the site
  4. No Field detected (before Redetect login fields)

Debug info

Before manually Redetect login fields:

[
    {
        "username": null,
        "password": null,
        "passwordInputs": [
            null
        ],
        "totp": null,
    }
]

Afterwards:

[
  {
    "username": "input#idToken1.form-control.input-lg",
    "password": "input#idToken2.form-control.input-lg",
    "passwordInputs": [
      "input#idToken2.form-control.input-lg"
    ],
    "totp": null,
  }
]

KeePassXC - 2.7.9
KeePassXC-Browser - 1.9.3
Operating system: Win64
Browser: Chrome/Chromium 129.0.0.0

@ahouse73
Copy link
Author

ahouse73 commented Oct 6, 2024

Maybe I understand the feature wrong, any help is appreciated!

@varjolintu
Copy link
Member

varjolintu commented Oct 6, 2024

Those should be automatically detected. So maybe it's a bug then, or the page contents are not loading early enough because of some animation etc. (Didn't try this yet)

@varjolintu varjolintu added the bug label Oct 6, 2024
@droidmonkey
Copy link
Member

I can reproduce this, but I think @varjolintu is correct. They are doing some weird "hide the body until the whole page loads" bullshit. The way they are doing this causes the extension to ignore the fields. In fact, they leave behind a display: none style attribute on the body element. The page is poorly constructed to be honest.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants