User configure Service.type does not take effect

[zyue110026]

We have noticed an instance of incorrect helming in one of your Kubernetes configuration files. Hardcoded or default configuration values in the template are considered anti-pattern and configurable values in the values.yaml file are not being respect, resulting in user-provided configurations never being applied. Additionally, we provide anecdotal evidence from trivy-operator#729 regarding the incorrect helming defect.

Service.type does not take effect when changed to a value other than default value 'ClusterIP'. This is due to missing implementation for this value in metric server service.yaml file:

charts/keda/templates/metrics-server/service.yaml

Line 28 in 43b0f51

spec:

.

Expected Behavior

Change Service.type to other type other than 'ClusterIP' can take effect

Actual Behavior

Only default value 'ClusterIP' take effect

Steps to Reproduce the Problem

1. install main version through helm chart
2. change Service.type to any other type instead of default type 'ClusterIP'
3. observe the service type still default type

Specifications

Recommend fix:

spec:
+  type: {{ .Values.service.type }}
   ports:
   - name: https
     port: {{ .Values.service.portHttps }}
     targetPort: {{ .Values.service.portHttpsTarget }}
     protocol: TCP

Or delete this value from documentation.