Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove player ID from room data on player client disconnect #13

Open
JoshuaKGoldberg opened this issue Sep 1, 2020 · 0 comments
Open

Remove player ID from room data on player client disconnect #13

JoshuaKGoldberg opened this issue Sep 1, 2020 · 0 comments
Labels
area: game runtime Improvements to the core game experience. good first issue You can do this as a way to learn about the code! ❤ status: accepting prs This issue is ready for a pull request. type: bug Something isn't working! Oh no!

Comments

@JoshuaKGoldberg
Copy link
Collaborator

Following #9: #10 fleshes introduces the concept of a room player, which is the client who has most recently caused the video to play. The player is the only client the server will listen to for updates to a playing video's currentTime.

Unfortunately, if that player leaves (in socket.io terms, disconnects), nothing indicates to the room that another client should become a new player. Bug: if a new client joins, the server won't have a recently updated currentTime to send them! 😱

Proposal: on client disconnect, if that client is the player, clear the room's player.

(Blocked on #10 being merged)
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working! Oh no! status: blocked Other work must be completed before this is tackled. area: game runtime Improvements to the core game experience. good first issue You can do this as a way to learn about the code! ❤ labels Sep 1, 2020
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 1, 2020
Open
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs This issue is ready for a pull request. and removed status: blocked Other work must be completed before this is tackled. labels Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: game runtime Improvements to the core game experience. good first issue You can do this as a way to learn about the code! ❤ status: accepting prs This issue is ready for a pull request. type: bug Something isn't working! Oh no!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg