Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream and delete? #2

Open
jeehoonkang opened this issue May 20, 2023 · 2 comments
Open

Upstream and delete? #2

jeehoonkang opened this issue May 20, 2023 · 2 comments
Assignees

Comments

@jeehoonkang
Copy link
Member

How about upstreaming this repository to https://github.com/stusmall/murmur3 and removing it?

@powergee
Copy link
Member

I think it would be a good idea to replace our fork with the upstream, because it has less change compared to the upstream, and our codes are less maintained.

I have tested PEBR with the upstream dependency, by running smr-benchmark. As it showed almost the same throughput, I think we can replace it with no worries.


Tested with NMTree, 64 threads and write-intensive workload:

  • Before: ops/s: 39431677, peak mem: 20452440
  • After: ops/s: 38930176, peak mem: 21030152

The throughput with the forked one(Before) is slightly better, as our fork has micro-optimization such as using a plain usize other than a Readable bytes buffer.

@jeehoonkang
Copy link
Member Author

I'd like to suggest we send a patch to the upstream repository https://github.com/stusmall/murmur3 and use the patched upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants