Emit Telemetry events

[stephanos]

Hello!

Telemetry is getting traction now that it's included in Phoenix and Ecto out-of-the-box. What's your stance on emitting telemetry events from this library? Would you welcome contributions?

It would allow users of this library to capture important metrics and send them to their monitoring solution. This way, we save everyone the time to instrument their own usage of this library.

Stephan

[stephanos]

Please let me know if you'd be open to merging anything like this so I know my time is well spent :)

[bjhaid]

I think emitting metrics from kafka_ex is a good idea, maybe start with a simple PoC to engage @dantswain and @joshuawscott interests

[dantswain]

I think this is a great idea. My only concerns are

• keep it general enough that any emitter can be used (i think Phoenix and ecto do a good job with this, essentially you just call a callback)
• don’t impact performance too much
• exactly what should we emit telemetry based on? There’s quite a lot going on in the client, it could be very chatty
• id prefer to not have to implement this twice (legacy and kayrock clients) if possible

[stephanos]

Thank you, I'll put this on my To Do list then :)
Feel free to close this issue if you want, I'll create a PR once I have something presentable.

[dimitarvp]

Did anything materialize from this idea? I can't find any mentions of "telemetry" in the code.