Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cluster-sync on external provider #252

Open
oshoval opened this issue Sep 26, 2024 · 4 comments · May be fixed by #255
Open

Support cluster-sync on external provider #252

oshoval opened this issue Sep 26, 2024 · 4 comments · May be fixed by #255
Assignees
@maiqueb
Labels
enhancement New feature or request

Comments

@oshoval
Copy link
Member

oshoval commented Sep 26, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
In order to develop / debug on external clusters, it would help to have a
make target cluster-sync that allows deploying on external provider (i.e kubevirtci)
Since the repo uses internal kind provider only.

Describe the solution you'd like
allow to export KUBEVIRT_PROVIDER=external
export KUBECONFIG=xyz
and then make cluster-sync as we have on all repos
that will clean build and deploy the local sources.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
@oshoval oshoval added the enhancement New feature or request label Sep 26, 2024
@oshoval
Copy link
Member Author

oshoval commented Sep 26, 2024 •
edited
Loading

It can help debugging the problems we see on CNAO for example
(it was auto assigned, not manually)

@oshoval
Copy link
Member Author

oshoval commented Sep 26, 2024 •
edited
Loading

since latest multus + this repo works on kind and not on kubevirtci
and the socket was changed
https://github.com/kubevirt/cluster-network-addons-operator/pull/1907/files#diff-c1699b853565a9da2cbc40c99bba985d4faf57da5a1141e6779de85637887077R114

i bet it is related (but just wild guess)
and if so, might affect macvtap as well ? it use kubevirtci still

@oshoval
Copy link
Member Author

oshoval commented Sep 30, 2024

/assign

i have a quick and dirty method that allows to debug it on kubevirtci
(out of 5 failures, 1 left to fix)
will post soon once i polish it

@oshoval
Copy link
Member Author

oshoval commented Sep 30, 2024 •
edited
Loading

CNAO has latest release now so it can be used instead the standalone + the leftover bug was found
we might not need to fix this issue but it can be nice to have, and i am pretty close to finish it if desired
else will drop the effort

it can help in the future

#255

@oshoval oshoval linked a pull request Oct 1, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maiqueb maiqueb

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cluster: Allow deploying controller on external cluster oshoval/multus-dynamic-networks-controller
2 participants
@maiqueb @oshoval