Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage check is failing on CI #7456

Closed
jtpio opened this issue Sep 10, 2024 · 2 comments · Fixed by jupyterlab/maintainer-tools#246
Closed

Coverage check is failing on CI #7456

jtpio opened this issue Sep 10, 2024 · 2 comments · Fixed by jupyterlab/maintainer-tools#246
Labels
maintenance status:Needs Triage Applied to issues that need triage
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Sep 10, 2024

Noticed on #7423 and the latest commit on main: https://github.com/jupyter/notebook/actions/runs/10771247335/job/29866697938

Run jupyterlab/maintainer-tools/.github/actions/report-coverage@v1
Run actions/setup-python@v5
Installed versions
Run python -Im pip install --upgrade coverage[toml]
Collecting coverage[toml]
  Downloading coverage-7.6.1-cp312-cp312-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (8.3 kB)
Downloading coverage-7.6.1-cp312-cp312-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl (239 kB)
Installing collected packages: coverage
Successfully installed coverage-7.6.1
Run actions/upload-artifact/merge@v4
Found 2 artifact(s)
Error: No artifacts found matching pattern 'coverage-*'
Run actions/upload-artifact@v4
Warning: No files were found with the provided path: htmlcov. No artifacts will be uploaded.
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Sep 10, 2024
@jtpio jtpio added this to the 7.3.0 milestone Sep 10, 2024
@jtpio
Copy link
Member Author

jtpio commented Sep 10, 2024

Looks like it could be because the previous step that should upload the coverage artifact does not upload anything:

image

@jtpio
Copy link
Member Author

jtpio commented Sep 10, 2024

Maybe it's related to the latest actions/upload-artifact@v4 which does not include hidden files anymore? https://github.com/actions/upload-artifact/releases/tag/v4.4.0

Also discussed in actions/upload-artifact#602

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance status:Needs Triage Applied to issues that need triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant