Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing icons in the news banner on 0.5.2 #223

Closed
jtpio opened this issue Feb 23, 2023 · 3 comments
Closed

Missing icons in the news banner on 0.5.2 #223

jtpio opened this issue Feb 23, 2023 · 3 comments

Comments

@jtpio
Copy link
Member

jtpio commented Feb 23, 2023

Trying Notebook 7, JupyterLab 4 and NBClassic installed together on Binder with https://gist.github.com/jtpio/35a72862c8be13dee31b61ebac2d9786

It appears the icons in the banner added in #215 are not rendered properly (using Firefox 110 on Fedora 37):

image
@jtpio
Copy link
Member Author

jtpio commented Feb 23, 2023

Ah a quick check seems to indicate this was fixed in #220 (but probably not released yet).

@echarles
Copy link
Member

Thx for reporting. This has been fixed in #220

We need to cut a release with that.

@jtpio
Copy link
Member Author

jtpio commented Feb 23, 2023

ok thanks for the confirmation.

Closing as fixed!

@jtpio jtpio closed this as completed Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@echarles @jtpio