Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer fixtures over hard-coded paths in tests #514

Closed
dlqqq opened this issue Apr 30, 2024 · 0 comments · Fixed by #516
Closed

Prefer fixtures over hard-coded paths in tests #514

dlqqq opened this issue Apr 30, 2024 · 0 comments · Fixed by #516

Comments

@dlqqq
Copy link
Collaborator

dlqqq commented Apr 30, 2024 

          Thank you for contributing this! I left some feedback below. The feedback mostly centers around using fixtures instead of hard-coded paths, so these fixtures can be easily re-used in future tests.

Originally posted by @dlqqq in #513 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dlqqq