Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit telemetry events on create job forms #471

Closed
sravyasdh opened this issue Jan 5, 2024 · 2 comments · Fixed by #472
Closed

Emit telemetry events on create job forms #471

sravyasdh opened this issue Jan 5, 2024 · 2 comments · Fixed by #472
Labels
enhancement New feature or request

Comments

@sravyasdh
Copy link

Problem

Would like to have telemetry data emitted for Compute type dropdown on create job page, and also for success / failure events after clicking on create job button.

Proposed Solution

  1. When a compute type is selected using the dropdown, the click event along with the selected compute type will be logged using the useEventLogger hook.
  2. In the case of successful job creation or job failure, the success/failure event is logged using the useEventLogger hook.
@sravyasdh sravyasdh added the enhancement New feature or request label Jan 5, 2024
@JasonWeill
Copy link
Collaborator

This is a follow-up to #432, fixed by #448.

@dlqqq
Copy link
Collaborator

dlqqq commented Jan 9, 2024

Per private conversation:

  • Telemetry in the "compute type" dropdown has to be implemented in the extension providing that component in the Advanced Options section.
  • However, we should emit telemetry events on success/failure for the Create Job, Create Job Definition, and Create Job from Job Definition forms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants