Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning vector, If 3> dimensions are 1 in zeros, etc #7

Open
aminya opened this issue Sep 22, 2019 · 0 comments
Open

Returning vector, If 3> dimensions are 1 in zeros, etc #7

aminya opened this issue Sep 22, 2019 · 0 comments
Labels

Comments

@aminya
Copy link
Member

aminya commented Sep 22, 2019

For array generation functions, If all of the dimensions that are supplied are 1, the resulting array should be a scalar.

Different tasks of this to do plan:

Achievement check:

we can get a :mat argument to do this, so this prevents type stability problems

onesM(:mat, 1, 2, 1, 1) # gives ones(1,2)
onesM(:mat, 2, 1, 1, 1) # gives ones(2,1)

isvectorM(:mat, ones(1,2,1,1)) # true
isvectorM(:mat, ones(1,1,2,1)) # false
@aminya aminya added the enhancement New feature or request label Sep 22, 2019
@aminya aminya closed this as completed Sep 23, 2019
@aminya aminya reopened this Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant