Consider using (nth 8 (syntax-ppss)) instead of js2-string-node-p, etc

[dgutov]

It should mean the same since js2-mode applies the necessary syntax-table properties. And then it would still work with minimal difference in js-mode too, even without js2-minor-mode.

The "minimal difference" would be only inside interpolations in template strings, I think.

[NicolasPetton]

@dgutov I'll think about it. In the beginning I expected to use js2-mode for more things than this, but if indeed I have no other need for it, I'll do as you suggest.

[dgutov]

As as aside, you might want to use different xref-js2--false-positive logic for definitions and references.

You can't have a definition inside a comment, but one can reference a function inside a comment, e.g. inside a @see JSDoc entry.

[NicolasPetton]

well, true, but is that really a reference? It's only a comment after all.

[dgutov]

Would the user expect to see that reference in the list? I'd like to see all the places where my function is referred to, e.g. to rename them all at once.