New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve launching and reporting of tests and lint #210

Open

ceball opened this issue Nov 5, 2020 · 1 comment

Labels

lang: javascript

Collaborator

ceball commented Nov 5, 2020 •

edited

Loading

Placeholder: fill in some content about a nice design that fits in with jupyter lab :) Are there other extensions we could be inspired by/steal from?

Currently:

You launch a test run or lint check from the Commands box (which seems fine).
You get a modal dialog asking if you want to run.
After clicking OK, you get no feedback until the result appears.
If the tests or lint don't complete within 5 seconds, you get an error (Increase default timeout for running cell tests #211).
If the tests or lint do complete within 5 seconds, you get an html report in a modal dialog.

ceball added the jupyterlab_celltests label

ceball mentioned this issue

Increase default timeout for running cell tests #211

Open

Collaborator

vidartf commented Nov 9, 2020

Some alternatives exist:

Do everything in modal dialogs (not recommended).
Create a main area widget that tracks progress and displays results.
Create a side bar widget that tracks progress and displays results.

The choice between the last two should probably be informed by the questions:

Should this always be readily available?
Do you want to be able to run tests for multiple notebooks simultaneously, and/or keep the results of multiple notebooks and/or test runs in different tabs?
etc.

timkpaine added lang: javascript and removed jupyterlab_celltests labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment