Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring and removing general test and send mail buttons #31

Open
tejaszambre opened this issue Nov 2, 2020 · 1 comment · May be fixed by #30
Open

Code refactoring and removing general test and send mail buttons #31

tejaszambre opened this issue Nov 2, 2020 · 1 comment · May be fixed by #30

Comments

@tejaszambre
Copy link

tejaszambre commented Nov 2, 2020

Sendmailer, testmail, sendtest from user controller need to be moved to the newsletter controller.

Some of the actions from the newsletter controller and the actions mentioned above(from user controller) have repeated code, we can merge those actions and make them generalized.

Actions which can be generalized and merged are:

  1. index, opt_in and opt_out
  2. test_opt_in, test_opt_out and testmail(from user controller)
  3. send_opt_out, send_opt_in and sendmailer(from user controller)
  4. send_opt_in_test, send_opt_out_test, sendtest(from user controller)

Also the test and send mail buttons in the top_navbar are confusing, we can move them below individual newsletter beside the edit and delete buttons.

@tejaszambre tejaszambre changed the title SMTP From address may not be blank Code refactoring and removing general test and send mail buttons Nov 2, 2020
@tejaszambre tejaszambre linked a pull request Nov 2, 2020 that will close this issue
@tejaszambre
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant