Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Remove WinCache? #37420

Closed
Hackwar opened this issue Mar 29, 2022 · 2 comments
Closed

[4.x] Remove WinCache? #37420

Hackwar opened this issue Mar 29, 2022 · 2 comments

Comments

@Hackwar
Copy link
Member

Hackwar commented Mar 29, 2022

I'm currently reviewing the setup for Appveyor and I stumbled over WinCache. WinCache seems to be the only caching solution for Windows IIS, but: This project seems to be completely and utterly dead. I had issues finding an official website and there are 3:

All these sites haven't had any changes in the last 2-6 years and the support seems to be nearly 0 everywhere. We wont be able to test WinCache with our current setup with PHP greater than 7.2, since that is the latest package available in the second link. But even that package claims to only be supported on PHP 5.2 and not newer. For PHP8 there seems to not be an ice cubes chance in hell to see a release.

We don't have any tests for WinCache in Joomla 4, although admittedly we have tests in the cache package of the framework. At the same time, the performance gain by using WinCache in an old PHP version is most likely negligable compared to using PHP 7.4 or later with built in Opcache. Looking at our tracker, the WinCache code does seem to be the most perfect code ever to be added to Joomla, since we seem to have only exactly one PR to fix one notice in everything. (The rest mentions WinCache in other contexts.) Redis by comparison has ~80 issues and ~60 PRs. Long story short: I doubt that anyone has used it in Joomla 4 and most likely no one is using it in Joomla 3 either.

That is why I'd like to propose to drop WinCache with the next minor release. Yes, I know that that is against SemVer, but considering the absolute minimal chance that anyone is even using this, I think it would be reasonable to do this. We aren't testing the code, we don't know if it works, we can't really add proper tests anymore for it... If you really want to keep this dead code, I'd at least like to remove the dead code from the appveyor setup.

@HLeithner
Copy link
Member

Already said in some other Issues/PR if SemVer doesn't fit the needs of Joomla! then please help finding a specification at joomla/rfc#29

For wincache it self we can remove it with 5.0, Please deprecate it in the framework with 3.0 and for Joomla 5.0 (introducing the deprecation with the next minor). I see no hurry to remove it since it doesn't break code other code and we don't know if someone is using it or not.

@Hackwar
Copy link
Member Author

Hackwar commented Mar 30, 2022

Ok, will deprecate it and leave the code otherwise where it is. However, I'm going to remove the few bits we have in the testing infrastructure, which is setup on each build to run tests we simply don't have. I don't see anyone creating tests for this, so I don't think the additional several minutes of runtime to setup this each time is worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants