Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a "Thank you" section on the about-page #840

Open
heiglandreas opened this issue Sep 25, 2019 · 5 comments
Open

Create a "Thank you" section on the about-page #840

heiglandreas opened this issue Sep 25, 2019 · 5 comments
Labels
easy-pick Tickets that are good for new contributors to pick up help wanted Stuff that we would love contributions for New Feature

Comments

@heiglandreas
Copy link
Member

On the "about"-page should be a section after "Get in touch" listing all contributors of the web, web2- and the api-repository like this:

## Thank you

This project is made possible by these people: a, b, c, d, d, e. Thank you!

The information can be retreived via the github-API. To make it easier to display and not call the github API every time the page is requested the information should be either cached or generated in an easy to consume format during deployment.

@heiglandreas heiglandreas added easy-pick Tickets that are good for new contributors to pick up help wanted Stuff that we would love contributions for New Feature labels Sep 25, 2019
@sujalpatel2209
Copy link

@heiglandreas I take care of this issue assign me Thank you.

@warren5236
Copy link
Contributor

I started looking into this. How would you like the content to be cached?

@heiglandreas
Copy link
Member Author

Best would actually be to generate the content via the CI run and then "just" include that content into the website.

So there would be a build-artifact that needs to be added to the deployment...

@warren5236
Copy link
Contributor

Would you be okay with using something like stefanzweifel/git-auto-commit-action to update a repository automatically (example https://github.com/warren5236/ScottsValueObjects/blob/main/.github/workflows/rector.yml) if the list of contributors changes? I could have a set of comments in the about twig and just replace the section between them with the list of contributors.

@heiglandreas
Copy link
Member Author

In general that seems OK. But the challenge I see here is that you'd be committing the modified template back to the repo and then the replacement variable is gone.

Itherwise can we define a file/variable that then gets replaced on runtime?

Also I'd need to check in detail on the deployment process as IIRC that is a manual step currently where code is deployed to the platform.sh repo. I think having that process within that step makes perhaps more sense.

Let me dig out the details on the deployment process and tgen decide where to put the step. Until then you can implement the actual step?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy-pick Tickets that are good for new contributors to pick up help wanted Stuff that we would love contributions for New Feature
Projects
None yet
Development

No branches or pull requests

3 participants