Accessibility: keyboard navigation on the toolbar #15054
+16
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution! |
|
@Calinteodor can you PTAL? |
|
@saghul is there any update on this PR? |
|
Jenkins test this please. |
@ahmadkadri It seems there is a failing test on Firefox. Please check it. Thank you. |
|
Please, could you run the test again. |
|
Jenkins test this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: when user use the keyboard navigation and have the focus on the toolbar. this focus should stay till the user tab out of the toolbar.
Actual Behavior: Toolbar menu disappear after a certain time even with the focus on it.
Expected Behavior: Toolbar should stay visible on focus (and closed on blur) and on mouse hover (and closed on mouse out).
before:
beforeFixToolbarKeyboardocus.mp4
after:
afterFixToolbarKeyboeadFocus.mp4
issue jitsi community: https://community.jitsi.org/t/accessibility-keyboard-navigation/133334