From 276d780d85bb5da2b911f24e2310e906b60983c7 Mon Sep 17 00:00:00 2001 From: Jordan Henderson Date: Thu, 27 Jun 2024 19:06:19 -0500 Subject: [PATCH] Remove TODO for features not to be implemented yet --- src/H5Znbit.c | 30 ++++++------------------------ src/H5Zscaleoffset.c | 5 +---- 2 files changed, 7 insertions(+), 28 deletions(-) diff --git a/src/H5Znbit.c b/src/H5Znbit.c index a2b467b2742..137775f2eca 100644 --- a/src/H5Znbit.c +++ b/src/H5Znbit.c @@ -239,10 +239,6 @@ H5Z__calc_parms_array(const H5T_t *type, size_t *cd_values_actual_nparms) HGOTO_ERROR(H5E_PLINE, H5E_BADTYPE, FAIL, "nbit cannot compute parameters for datatype"); break; - case H5T_COMPLEX: - /* TODO */ - break; - case H5T_TIME: case H5T_STRING: case H5T_BITFIELD: @@ -250,6 +246,7 @@ H5Z__calc_parms_array(const H5T_t *type, size_t *cd_values_actual_nparms) case H5T_REFERENCE: case H5T_ENUM: case H5T_VLEN: + case H5T_COMPLEX: /* Other datatype classes: nbit does no compression */ H5Z__calc_parms_nooptype(cd_values_actual_nparms); break; @@ -337,10 +334,6 @@ H5Z__calc_parms_compound(const H5T_t *type, size_t *cd_values_actual_nparms) HGOTO_ERROR(H5E_PLINE, H5E_BADTYPE, FAIL, "nbit cannot compute parameters for datatype"); break; - case H5T_COMPLEX: - /* TODO */ - break; - case H5T_TIME: case H5T_STRING: case H5T_BITFIELD: @@ -348,6 +341,7 @@ H5Z__calc_parms_compound(const H5T_t *type, size_t *cd_values_actual_nparms) case H5T_REFERENCE: case H5T_ENUM: case H5T_VLEN: + case H5T_COMPLEX: /* Other datatype classes: nbit does no compression */ H5Z__calc_parms_nooptype(cd_values_actual_nparms); break; @@ -572,16 +566,13 @@ H5Z__set_parms_array(const H5T_t *type, unsigned *cd_values_index, unsigned cd_v HGOTO_ERROR(H5E_PLINE, H5E_BADTYPE, FAIL, "nbit cannot set parameters for datatype"); break; - case H5T_COMPLEX: - /* TODO */ - break; - case H5T_TIME: case H5T_STRING: case H5T_BITFIELD: case H5T_OPAQUE: case H5T_REFERENCE: case H5T_ENUM: + case H5T_COMPLEX: if (H5Z__set_parms_nooptype(dtype_base, cd_values_index, cd_values) < 0) HGOTO_ERROR(H5E_PLINE, H5E_BADTYPE, FAIL, "nbit cannot set parameters for datatype"); break; @@ -713,16 +704,13 @@ H5Z__set_parms_compound(const H5T_t *type, unsigned *cd_values_index, unsigned c } break; - case H5T_COMPLEX: - /* TODO */ - break; - case H5T_TIME: case H5T_STRING: case H5T_BITFIELD: case H5T_OPAQUE: case H5T_REFERENCE: case H5T_ENUM: + case H5T_COMPLEX: /* other datatype that nbit does no compression */ if (H5Z__set_parms_nooptype(dtype_member, cd_values_index, cd_values) < 0) HGOTO_ERROR(H5E_PLINE, H5E_BADTYPE, FAIL, "nbit cannot set parameters for datatype"); @@ -809,10 +797,6 @@ H5Z__set_local_nbit(hid_t dcpl_id, hid_t type_id, hid_t space_id) HGOTO_ERROR(H5E_PLINE, H5E_BADTYPE, FAIL, "nbit cannot compute parameters for datatype"); break; - case H5T_COMPLEX: - /* TODO */ - break; - case H5T_TIME: case H5T_STRING: case H5T_BITFIELD: @@ -820,6 +804,7 @@ H5Z__set_local_nbit(hid_t dcpl_id, hid_t type_id, hid_t space_id) case H5T_REFERENCE: case H5T_ENUM: case H5T_VLEN: + case H5T_COMPLEX: /* No need to calculate other datatypes at top level */ break; @@ -885,10 +870,6 @@ H5Z__set_local_nbit(hid_t dcpl_id, hid_t type_id, hid_t space_id) HGOTO_ERROR(H5E_PLINE, H5E_BADTYPE, FAIL, "nbit cannot set parameters for datatype"); break; - case H5T_COMPLEX: - /* TODO */ - break; - case H5T_TIME: case H5T_STRING: case H5T_BITFIELD: @@ -896,6 +877,7 @@ H5Z__set_local_nbit(hid_t dcpl_id, hid_t type_id, hid_t space_id) case H5T_REFERENCE: case H5T_ENUM: case H5T_VLEN: + case H5T_COMPLEX: /* No need to set parameters for other datatypes at top level */ break; diff --git a/src/H5Zscaleoffset.c b/src/H5Zscaleoffset.c index b5dfe2ce1bf..f074e7b12f3 100644 --- a/src/H5Zscaleoffset.c +++ b/src/H5Zscaleoffset.c @@ -978,10 +978,6 @@ H5Z__set_local_scaleoffset(hid_t dcpl_id, hid_t type_id, hid_t space_id) cd_values[H5Z_SCALEOFFSET_PARM_CLASS] = H5Z_SCALEOFFSET_CLS_FLOAT; break; - case H5T_COMPLEX: - /* TODO */ - break; - case H5T_NO_CLASS: case H5T_TIME: case H5T_STRING: @@ -992,6 +988,7 @@ H5Z__set_local_scaleoffset(hid_t dcpl_id, hid_t type_id, hid_t space_id) case H5T_ENUM: case H5T_VLEN: case H5T_ARRAY: + case H5T_COMPLEX: case H5T_NCLASSES: default: HGOTO_ERROR(H5E_PLINE, H5E_BADTYPE, FAIL, "datatype class not supported by scaleoffset");