Support element initialization via components attributes Hash #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update github actions * Setup build matrix with ruby versions between 2.5.9 and 3.2.2 * Restrict gem to rails versions >= 5.1 and < 7.0 * Update development dependencies
Renames the components attributes Hash to attributes_or_elements. Enhances the initialize_elements method to lookup available element values from the attributes_or_elements Hash and assigns them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was able to support element initialization via components attributes Hash by:
values from the attributes_or_elements Hash and assigning them.
Fixes #53 and #51 (this PR superseeds PR #52)
See relevant changes in a71fe1b
Any thoughts? Is a timely merge possible?
Looking forward!