-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Error: write after end" followed by npm-register crashing #90
Comments
Not sure if related, but seeing this in the logs too (app does not crash though):
|
@jessebye do you know what user actions were taking place when the error occured? |
@dgautsch Most likely just |
this means the response timed out. Koa-timeout kills the request but then the code still tries to write to it. |
@jdxcode maybe a case for better error handling then? This was crashing |
I’m certainly not arguing this is ok behavior, I’m just giving some color around why it’s happening. I’ve seen these errors come in on our installation and I don’t know if it’s causing the server to crash or not, but because we run this on a couple of instances in tandem and if one crashes another one simply replaces it it’s not causing us any practical issue. My point again isn’t that this is okay, but it’s also not something worth investigating from my side right now. I’ll certainly accept a PR if someone wants to explore the behavior the CLI has on timeouts though. |
@jessebye I'll have to narrow down the steps to reproduce. I can start going over the code and looking for areas where we're not error handling. |
Well, I'm having the same error as @jessebye, the error:
Is repeated a lot of times, and it finally die with the error: However I'm concerned with the opbeat login error. Why is it trying to loggin to opbeat if I have not the opbeat details defined? I think since Opbeat is an online profiling platform the initialization must be optional. Maybe an ENV variable to disable/enable opbeat? Thanks |
@protheantom does this happen during npm install like jessebye mentioned? |
@protheantom not running in Docker. But I see the same logging errors when npm-register crashes. We are running into this bug seemingly once every few weeks now. Just about ready to jump over to a different NPM registry solution since we've had so much trouble with this 😢 |
Saddest part that other solutions doesn't follow 12factorapp and this brings troubles deploying registry with a docker. I mean how can people use only config file for configuration? This solution doesn't scale. That's why this project must live! |
Does this still persist with v2.8.1? |
@jessebye and @protheantom I'm trying to shore up old bugs and this still seems relevant. I understand If you both had to move on at this point, but if you happen to still be running npm-register is this still a problem? |
Just started seeing this error on our npm-register server (running version 2.5.2) last night:
After this error, the app dies.
The text was updated successfully, but these errors were encountered: