Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement ideas and bugs: McEliece/Rainbow (ErrorCorrectingCodes/MultivatiateCrypto) #328

Open
17 of 22 tasks
simlei opened this issue Aug 4, 2020 · 3 comments
Open
17 of 22 tasks
Assignees

Comments

@simlei
Copy link
Member

simlei commented Aug 4, 2020

This concerns the plugins:

  • McEliece (crypto/org.jcryptool.visual.errorcorrectingcodes)
  • Rainbow (crypto/org.jcryptool.visual.rainbow)

Textual issues

Help system

  • DE/McEliece: question mark button does not open help; help is however present ("TOC/Visual/Fehlerkorrektur Codes") but empty (needs translation @ B.E.) (0a4dcfb)
  • DE/Rainbow : question mark button does not open help; help is not present in the source (5993f17)
  • EN/McEliece: question mark button does not open help; help is however present ("TOC/Visual/McEliece cryptographic system") (5993f17)
  • EN/Rainbow : question mark button does not open help; help is however present ("TOC/Visual/Multivariate Cryptography") (0a4dcfb)

Translation

Layout

  • Rainbow/Multivar.Krypto -- Layout: Die Formeln unter "Coefficient distribution" sind breiter als der Bereich, ab dem der horizontale Scrollbar angezeigt wird.
  • Rainbow/Multivar.Krypto -- Layout: Auch wenn ich n=7 setze, wird der Platz bis zur Gruppierung "Algorithm details" nicht gnaz beansprucht. Wenn das so ist, dann bitte Gruppierung "Algorithm details" nach oben schieben.
  • McEliece: Alice and Bob's private key areas in "Algorithmus" (second tab of McEliece) are way big.
    • McEliece: Third tab: better layout (space waste), less intrusive colors

image

  • Zuviel leerer Platz unter "Coefficient distribution". Dafür wurde unter "Algorithm details" zuerst ein vertikaler Scrollbar nötig.
    • Die Leerzeile vor "----Public Key----" in "Coefficient distribution" rausnehmen.
  • Die senkrechte Trennlinie verschiebbar machen. Ich würde es so einstellen, dass die linke Seite etwas weniger Platz hat und dafür die rechte mehr. Dann würde man auch alle Koeffizienten (wie O_23) sehen. Wenn unter "Coefficient distribution" nicht alles angezeigt werden kann, sollte es einen horizontaen Scrollbar haben.
@simlei simlei added this to the Final 1.0.0 milestone Aug 4, 2020
@simlei simlei self-assigned this Aug 4, 2020
@simlei
Copy link
Member Author

simlei commented Aug 4, 2020

  • @simlei Apply Title-And-Description generic composites to all views and tabs

@simlei simlei changed the title Finalize McEliece/Rainbow (ErrorCorrectingCodes/MultivatiateCrypto) Finish McEliece/Rainbow (ErrorCorrectingCodes/MultivatiateCrypto) Aug 4, 2020
@simlei simlei removed this from the Final 1.0.0 milestone Oct 20, 2020
@simlei simlei changed the title Finish McEliece/Rainbow (ErrorCorrectingCodes/MultivatiateCrypto) Improvement ideas and bugs: McEliece/Rainbow (ErrorCorrectingCodes/MultivatiateCrypto) Nov 3, 2021
@simlei
Copy link
Member Author

simlei commented Nov 4, 2021

Bugs:

McEliece Cryptosystem: the "Decrypt" button yields an error with default inputs and "Generate keys" > "Encrypt" > "Decrypt"
image

java.lang.ArithmeticException: length mismatch
	at org.bouncycastle.pqc.math.linearalgebra.GF2Vector.<init>(GF2Vector.java:122)
	at org.bouncycastle.pqc.math.linearalgebra.GF2Vector.OS2VP(GF2Vector.java:182)
	at org.bouncycastle.pqc.crypto.mceliece.McElieceCipher.messageDecrypt(Unknown Source)
	at org.jcryptool.visual.errorcorrectingcodes.algorithm.McElieceCrypto.decrypt(McElieceCrypto.java:166)
	at org.jcryptool.visual.errorcorrectingcodes.ui.views.McElieceView.performDecryption(McElieceView.java:268)
	at org.jcryptool.visual.errorcorrectingcodes.ui.views.McElieceView.lambda$4(McElieceView.java:197)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)

@simlei
Copy link
Member Author

simlei commented Nov 4, 2021

Functionality improvements

  • Rainbow: Could there be a log file for LES, ideally to open in an editor, so that the parameters and ideally, interim steps can be looked into?
  • Rainbow: provide way to manipulate the parameters other than just the ordinality of the layers — there is little room for playing around with the algorithm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant