diff --git a/pom.xml b/pom.xml index ba13a0315..a08081d3d 100644 --- a/pom.xml +++ b/pom.xml @@ -35,7 +35,7 @@ com.jcabi jcabi - 1.15 + 1.16 jcabi-github 1.0-SNAPSHOT @@ -86,7 +86,7 @@ com.jcabi.incubator xembly - 0.17 + 0.19.1 com.jcabi diff --git a/src/main/java/com/jcabi/github/Bulk.java b/src/main/java/com/jcabi/github/Bulk.java index cc79a35e1..a44e71d6e 100644 --- a/src/main/java/com/jcabi/github/Bulk.java +++ b/src/main/java/com/jcabi/github/Bulk.java @@ -94,10 +94,11 @@ public Bulk( ) { if (items instanceof RtPagination) { final RtPagination page = RtPagination.class.cast(items); - final RtPagination.Mapping mapping = page.mapping(); + final RtValuePagination.Mapping mapping = + page.mapping(); this.origin = new RtPagination( page.request(), - new RtPagination.Mapping() { + new RtValuePagination.Mapping() { @Override public T map(final JsonObject object) { final T item = mapping.map(object); diff --git a/src/main/java/com/jcabi/github/RtAssignees.java b/src/main/java/com/jcabi/github/RtAssignees.java index a624eabe4..99eab76cf 100644 --- a/src/main/java/com/jcabi/github/RtAssignees.java +++ b/src/main/java/com/jcabi/github/RtAssignees.java @@ -90,7 +90,7 @@ final class RtAssignees implements Assignees { public Iterable iterate() { return new RtPagination( this.request, - new RtPagination.Mapping() { + new RtValuePagination.Mapping() { @Override public User map(final JsonObject object) { return new RtUser( diff --git a/src/main/java/com/jcabi/github/RtCollaborators.java b/src/main/java/com/jcabi/github/RtCollaborators.java index cfe6a7daa..425170994 100644 --- a/src/main/java/com/jcabi/github/RtCollaborators.java +++ b/src/main/java/com/jcabi/github/RtCollaborators.java @@ -136,7 +136,7 @@ public void remove( public Iterable iterate() { return new RtPagination( this.request, - new RtPagination.Mapping() { + new RtValuePagination.Mapping() { @Override public User map(final JsonObject object) { return RtCollaborators.this.owner.github().users() diff --git a/src/main/java/com/jcabi/github/RtComments.java b/src/main/java/com/jcabi/github/RtComments.java index 8c058478d..e4dc483fb 100644 --- a/src/main/java/com/jcabi/github/RtComments.java +++ b/src/main/java/com/jcabi/github/RtComments.java @@ -130,7 +130,7 @@ public Comment post(@NotNull(message = "post text can't be NULL") public Iterable iterate() { return new RtPagination( this.request, - new RtPagination.Mapping() { + new RtValuePagination.Mapping() { @Override public Comment map(final JsonObject object) { return RtComments.this.get(object.getInt("id")); diff --git a/src/main/java/com/jcabi/github/RtCommits.java b/src/main/java/com/jcabi/github/RtCommits.java index 953af7d82..9dc4bf146 100644 --- a/src/main/java/com/jcabi/github/RtCommits.java +++ b/src/main/java/com/jcabi/github/RtCommits.java @@ -48,7 +48,7 @@ @Immutable @Loggable(Loggable.DEBUG) @EqualsAndHashCode(of = {"entry", "request", "owner" }) -public class RtCommits implements Commits { +public final class RtCommits implements Commits { /** * RESTful API entry point. */ @@ -83,16 +83,16 @@ public class RtCommits implements Commits { @Override @NotNull(message = "Repository is never NULL") - public final Repo repo() { + public Repo repo() { return this.owner; } @Override @NotNull(message = "tag is never NULL") - public final Commit create( + public Commit create( @NotNull(message = "params can't be NULL") final JsonObject params ) throws IOException { - final Commit created = this.get( + return this.get( this.request.method(Request.POST) .body().set(params).back() .fetch().as(RestResponse.class) @@ -100,12 +100,11 @@ public final Commit create( .as(JsonResponse.class) .json().readObject().getString("sha") ); - return created; } @Override @NotNull(message = "tag is never NULL") - public final Commit get( + public Commit get( @NotNull(message = "sha can't be NULL") final String sha ) { return new RtCommit(this.entry, this.owner, sha); diff --git a/src/main/java/com/jcabi/github/RtContents.java b/src/main/java/com/jcabi/github/RtContents.java index 39821b1bb..7c009a35f 100644 --- a/src/main/java/com/jcabi/github/RtContents.java +++ b/src/main/java/com/jcabi/github/RtContents.java @@ -189,7 +189,7 @@ public Iterable iterate( return new RtPagination( this.request.method(Request.GET) .uri().path(path).queryParam("ref", ref).back(), - new RtPagination.Mapping() { + new RtValuePagination.Mapping() { @Override public Content map(final JsonObject object) { return new RtContent( diff --git a/src/main/java/com/jcabi/github/RtDeployKeys.java b/src/main/java/com/jcabi/github/RtDeployKeys.java index dbc8125c3..8d7bce066 100644 --- a/src/main/java/com/jcabi/github/RtDeployKeys.java +++ b/src/main/java/com/jcabi/github/RtDeployKeys.java @@ -94,7 +94,7 @@ public Repo repo() { public Iterable iterate() { return new RtPagination( this.request, - new RtPagination.Mapping() { + new RtValuePagination.Mapping() { @Override public DeployKey map(final JsonObject object) { //@checkstyle MultipleStringLiteralsCheck (1 line) diff --git a/src/main/java/com/jcabi/github/RtForks.java b/src/main/java/com/jcabi/github/RtForks.java index ba3062c98..f8fd91ef7 100644 --- a/src/main/java/com/jcabi/github/RtForks.java +++ b/src/main/java/com/jcabi/github/RtForks.java @@ -96,7 +96,7 @@ public Iterable iterate( @NotNull(message = "sort can't be NULL") final String sort) { return new RtPagination( this.request.uri().queryParam("sort", sort).back(), - new RtPagination.Mapping() { + new RtValuePagination.Mapping() { @Override public Fork map(final JsonObject object) { return RtForks.this.get(object.getInt(ID)); diff --git a/src/main/java/com/jcabi/github/RtGistComments.java b/src/main/java/com/jcabi/github/RtGistComments.java index a240e16c4..07874d47b 100644 --- a/src/main/java/com/jcabi/github/RtGistComments.java +++ b/src/main/java/com/jcabi/github/RtGistComments.java @@ -126,7 +126,7 @@ public GistComment post( public Iterable iterate() { return new RtPagination( this.request, - new RtPagination.Mapping() { + new RtValuePagination.Mapping() { @Override public GistComment map(final JsonObject object) { return RtGistComments.this.get(object.getInt("id")); diff --git a/src/main/java/com/jcabi/github/RtGists.java b/src/main/java/com/jcabi/github/RtGists.java index 97d76b53f..6469c7e72 100644 --- a/src/main/java/com/jcabi/github/RtGists.java +++ b/src/main/java/com/jcabi/github/RtGists.java @@ -133,7 +133,7 @@ public Gist get(@NotNull(message = "gist name can't be NULL") public Iterable iterate() { return new RtPagination( this.request, - new RtPagination.Mapping() { + new RtValuePagination.Mapping() { @Override public Gist map(final JsonObject object) { return RtGists.this.get(object.getString("id")); diff --git a/src/main/java/com/jcabi/github/RtHooks.java b/src/main/java/com/jcabi/github/RtHooks.java index edea1790e..3f3e176e1 100644 --- a/src/main/java/com/jcabi/github/RtHooks.java +++ b/src/main/java/com/jcabi/github/RtHooks.java @@ -97,7 +97,7 @@ public Repo repo() { public Iterable iterate() { return new RtPagination( this.request, - new RtPagination.Mapping() { + new RtValuePagination.Mapping() { @Override public Hook map(final JsonObject object) { // @checkstyle MultipleStringLiterals (1 line) diff --git a/src/main/java/com/jcabi/github/RtIssue.java b/src/main/java/com/jcabi/github/RtIssue.java index 1f768e8f6..4f941ff84 100644 --- a/src/main/java/com/jcabi/github/RtIssue.java +++ b/src/main/java/com/jcabi/github/RtIssue.java @@ -128,7 +128,7 @@ public IssueLabels labels() { public Iterable events() { return new RtPagination( this.request.uri().path("/events").back(), - new RtPagination.Mapping() { + new RtValuePagination.Mapping() { @Override public Event map(final JsonObject object) { return new RtEvent( diff --git a/src/main/java/com/jcabi/github/RtIssueLabels.java b/src/main/java/com/jcabi/github/RtIssueLabels.java index a8b8ea486..a16764b12 100644 --- a/src/main/java/com/jcabi/github/RtIssueLabels.java +++ b/src/main/java/com/jcabi/github/RtIssueLabels.java @@ -158,7 +158,7 @@ public void clear() throws IOException { public Iterable