-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SET-722 Refactor cci_worker to perform automation smoothly #248
Conversation
cci_worker.yml
Outdated
- ansible.builtin.include_role: | ||
name: "{{ taskfiles }}" | ||
with_items: | ||
- cci_worker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this included twice?
- name: "Ensure jaegertracing docker image is downloaded for tests" | ||
containers.podman.podman_image: | ||
name: "quay.io/jaegertracing/all-in-one:latest" | ||
become: yes | ||
become_user: "{{cci_worker_username}}" | ||
|
||
tasks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do all of those become post_tasks
? why?
path: "/home/{{ cci_worker_username }}/.m2/" | ||
state: directory | ||
mode: "0755" | ||
owner: "{{ cci_worker_username }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add group ownership as well group: "{{ cci_worker_username }}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done!
f65d20f
to
3d04b67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Issue: https://issues.redhat.com/browse/SET-722