Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SET-651] Enable vault role in playbooks #233

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

gaol
Copy link
Contributor

@gaol gaol commented Dec 15, 2023

Issue: https://issues.redhat.com/browse/SET-651

This is a follow up PR of #232.

This PR tries to enable vault role in the playbooks which may need access credential information.

  • It makes sure the hvac python library installed according to the requirement from the community.hashi_vault ansible collection.
  • It assumes the vault related configurations are in vars/vault.yml file
  • It has the vault role as the first task in the pre_tasks section to prepare needed sensitive values before other tasks.

Copy link
Collaborator

@rpelisse rpelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rpelisse rpelisse merged commit ecc29a3 into jboss-set:main Jan 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants