Changing JSON data based on issue 29 and 30 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khermano
force-pushed
the
build-trigger-29_from_main
branch
from
3415bdb
to
41612a7
Compare
petrberan
reviewed
Sep 13, 2024
|
|
||
| @NotNull | ||
| @Valid | ||
| public Environment environment; | ||
| public String publicTag; |
There was a problem hiding this comment.
No longer true, we should get access to Gitlab.cee (as in the tag doesn't have to only public)
petrberan
reviewed
Sep 13, 2024
|
|
||
| @NotNull | ||
| public String revision; | ||
| public String version; |
petrberan
reviewed
Sep 13, 2024
|
|
||
| public static String getJsonStreamName(String streamFromFrontend) { | ||
| for (Stream stream : Stream.values()) { | ||
| if (stream.frontEnd.equals(streamFromFrontend) || stream.backEnd.equals(streamFromFrontend)) { |
There was a problem hiding this comment.
In the end, the FE should send only BE data, meaning that we will change this later to just stream.backEnd.equals(streamFromFrontend) , but let's keep this for now
petrberan
reviewed
Sep 13, 2024
| .contentType(MediaType.APPLICATION_JSON) | ||
| .when().post("/build-trigger/trigger") | ||
| .then() | ||
| .statusCode(500); |
There was a problem hiding this comment.
Now this got me thinking - in case we receive a stream that is not in the list, the correct code we should be returning is not 500, but 422
khermano
force-pushed
the
build-trigger-29_from_main
branch
from
41612a7
to
0b601d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #29