file patcher for code weaving (eg module timer, template preprocessing, code generation)

[naturallymitchell]

No description provided.

[naturallymitchell]

jazzdotdev/flute@626a18f
jazzdotdev/flute@cd016fa

https://github.com/foundpatterns/lighttouch-base/blob/cb430ac40f0df737f30cdb117d61b112f64861ad/loaders/themes/extends_rewriter.lua

[aleksanderwlodarczyk]

aleksanderwlodarczyk/file-patcher@fe4e86f

Should it be only for file processing or for loading too? f.e we have theme loader in lighttouch-base that patches the themes and load them. This tool should be universal way of file patching, right?

[naturallymitchell]

Yes

[naturallymitchell]

Should work for each case

[naturallymitchell]

What you're doing doesn't look right. It should only have the mechanisms. It shouldn't know about "rules" and "themes" etc. Lighttouch should use that. Other things should use it too for its common mechanisms

[aleksanderwlodarczyk]

Okay, but if I started this way I decided to finish theme patching and then refactor it to be mechanism only. But how do you want the patcher to recognize which mechanism should it use?

So far the first 'milestone' is working outsourced mechanisms for rules, actions and themes

aleksanderwlodarczyk/file-patcher@1d4a04c

[aleksanderwlodarczyk]

I was trying to update it today but I can't understand how should we have multiple mechanisms and do not switching it with "rules", "actions"? Do you want it to be just preprocessors table and add such a preprocessors in each app?

[naturallymitchell]

sounds good

[aleksanderwlodarczyk]

Okay, I think I almost got what you want. Here at aleksanderwlodarczyk/file-patcher@4cc39ec I got preety clean solution but Lua seems to has problems with 'unpack' which I am using first time (https://www.lua.org/pil/5.2.html)

I will try to fix this problem because 'unpack' seems to be ideal to use it here where we need functions with various parameters number

[naturallymitchell]

Lighttouch should also have a dependent patch to use the file patcher

[aleksanderwlodarczyk]

Okay, so current version is working for any number of parameters
aleksanderwlodarczyk/file-patcher@4e36521

In our version of Lua we should use (...) instead of unpack(args) (https://stackoverflow.com/questions/38749099/lua-variable-length-function-arguments-are-nil/38749326)

Should I start refactoring lighttouch to use this patcher?

[naturallymitchell]

it looks pretty worthless, tbh

I really don't know what if anything you've accomplished.

mind filling me?

[aleksanderwlodarczyk]

Worthless? I asked you if you want patching modes - you said you want, I did the modes, you said it should be more universal, I asked should it be only table for preprocessors and each app should add their own - you said it sounds good and now you are saying it is worthless? Funny.... Really funny

[naturallymitchell]

If you're gonna go off doing your own thing, idk how to help other than to wait and see what you come up with.

I'm trying to reach you on discord so we can dialogue.

[naturallymitchell]

I went back and looked again for what I had a hunch I must have been missing..

In fact the code you made was there, but somewhere different than where you linked, 2ac7a01#diff-a71c5bb21ea277cd777a78278660cd85

So, it seems like you were on the right track.. Yes I do want you to refactor lighttouch.

(Sorry for jumping to the belief that you had failed; I should have dug deeper.)

Do you still want to carry this though?