Remove custom jquery #301
Remove custom jquery #301
Conversation
|
Fun fact, to actually make sure django jQuery is loaded, one needed to set But I can't see this documented anywhere. Apparently JQUERY_URL = None was the default for a while, and then got changed. I can only see some comments about this in there #206...
|
| @@ -1,10 +0,0 @@ | |||
| ## Settings | |||
|
|
|||
| `JQUERY_URL` | |||
There was a problem hiding this comment.
Rather than delete this file, we should mention SMART_SELECTS_URL_PREFIX
There was a problem hiding this comment.
What does SMART_SELECTS_URL_PREFIX do exactly? From what I can tell, it prepend the autocomplete endpoints. Is that it?
|
@leibowitz I would like to merge this one. Could you please rebase it against master to fix the conflict? |
leibowitz
force-pushed
the
remove_jquery_settings
branch
from
97b98a8
to
fd7536c
Compare
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
===========================================
- Coverage 80.42% 67.88% -12.54%
===========================================
Files 8 8
Lines 470 464 -6
Branches 68 65 -3
===========================================
- Hits 378 315 -63
- Misses 60 136 +76
+ Partials 32 13 -19
Continue to review full report at Codecov.
|
|
@manelclos happy to try to bring this PR/branch up-to-date, if you are still willing to merge it? I did update it a year ago but nobody seems to have been bold enough to merge. I guess there were some concerns? In my opinion depending on jquery 2.2.0 is not ideal. Especially since django already bundles jquery... I don't really see the need. Also, this causes a myriad of issues with other django extensions, I'm not going to get into... mainly due to events not being triggered due to multiple versions of jquery being loaded |
|
Hi @leibowitz, back then I wanted to merge simple PRs to have a "last" compatible release, then merge this and the one removing Django 2.2 support to have a new major version release. But the Django 2.2 PR was merged without prior notice. This PR was ok, I'm happy to look at it again if you update it. We should look into other needed modifications before we bump the major version. |
Remove both
JQUERY_URLandUSE_DJANGO_JQUERYand always use Django jQuery version.See #270 (comment)
BTW, jQuery 2.2.0 is quite old
https://snyk.io/vuln/npm:[email protected]