-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please remove the copy of ssrZ (or rename it) #15
Comments
There is quite a lot of overlap in the content of these two files, so the ideal solution would be if both projects consolidated what they need in MathComp itself. However, since MCZify is expected to be used in more places (due to its status as "proof automation package"), maybe |
Looking at the history of both files, assuming 2017 < 2021, should invalidate this statement. |
IMO, the simplest is to remove |
@strub : sorry, I should have properly investigated this - I am a bit under water with breakages in Coq Platform these days. |
I managed to remove nearly all the contents of thus file. I al not sure it is worth consolidating anything then. |
That sounds good to me, then all that may be needed is to rename the file with the remaining code (and start to depend on |
At least I would say it would be nice to have only one source (library) of structure instances for the standard binary integer type |
Note: These are not my packages Starting with `coq-mathcomp-word` `2.0`, this package lives in the namespace `mathcomp.word`, and it includes a file `ssrZ` that conflicts with a corresponding file from `coq-mathcomp-zify`. See jasmin-lang/coqword#15 for the discussion upstream. `coq-mathcomp-algebra-tactics <= 1.0.0` imports `ssrZ` while only qualifying `mathcomp` and not `mathcomp.zify`. This has been fixed in `dev`, but is still a problem for the released packages: https://github.com/math-comp/algebra-tactics/blob/fb87fb0434c17e825b22e3bac9904c8e4f6cd1c2/theories/ring.v#L5 We declare a conflict with `coq-mathcomp-word.2.0` to resolve this.
Without a qualified import `coq-mathcomp-apery` is incompatible with `coq-mathcomp-word`. See also jasmin-lang/coqword#15
What is the status of this? #17 renamed ssrZ.v into word_ssrZ.v, but the proper fix in my opinion is to remove word_ssrZ.v, as mentioned here. |
The status is that we should implement this. #17 is a fix hack to solve the name clash issue. |
Of course I would prefer a proper solution. If this is not possible in say 2 weeks, I would go with the hack, so that the proper solution can be done properly. |
I accepted your PR so that you can go with the hack. |
Ah yes - and there is also a new tag. So all what is missing is that you confirm in #18 that this is the tag you want to see in Coq Platform. Sorry for this rather verbose protocol - it helps to avoid mistakes. |
@strub : the change in the install path in b94f002 from
CoqWord
tomathcomp/word
(afair it was suggested by @palmskog) has the effect that other packages which do aFrom mathcomp Require ssrZ
now fail, because there are two ssrZ files under mathcomp:This is really quite bad since ssrZ is a common thing to require.
I don't know why you copied ssrZ. If it is just for convenience / historic reasons please consider removing it and installing zify via opam. Otherwise please rename it.
In Coq Platform I am still using version 1.1 for the reason as mentioned here
The text was updated successfully, but these errors were encountered: