Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service crashes when webapp requests a recording that doesn't exist #212

Open
MrFabio opened this issue Aug 1, 2023 · 0 comments
Open

Comments

@MrFabio
Copy link

MrFabio commented Aug 1, 2023

In the webapp, if we open a recent call and that call doesn't have a recording in the bucket (due to a api-server update, the old calls don't have a recording yet), the api-server crashes with the following log (and a few seconds later I'm logged out of the webapp):

ApiError: No such object: my-bucket-recordings/2023/08/01/abcd5559-aaaa-1111-a12e-9a0f48fce600.mp3
    at new ApiError (/opt/app/node_modules/@google-cloud/storage/build/src/nodejs-common/util.js:80:15)
    at Util.parseHttpRespMessage (/opt/app/node_modules/@google-cloud/storage/build/src/nodejs-common/util.js:182:41)
    at Util.handleResp (/opt/app/node_modules/@google-cloud/storage/build/src/nodejs-common/util.js:156:76)
    at Duplexify.<anonymous> (/opt/app/node_modules/@google-cloud/storage/build/src/file.js:1072:38)
    at Duplexify.emit (node:events:513:28)
    at PassThrough.emit (node:events:513:28)
    at onResponse (/opt/app/node_modules/retry-request/index.js:234:19)
    at PassThrough.<anonymous> (/opt/app/node_modules/retry-request/index.js:165:11)
    at PassThrough.emit (node:events:525:35)
    at /opt/app/node_modules/teeny-request/build/src/index.js:191:27

With the google bucket vendor and using api-server 0.8.4-4

If the recording doesn't exist, perhaps don't show the waveform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant