Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Frontend Failing Test: paddle - comparison.numpy.greater_equal #28701

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

ZJay07
Copy link
Contributor

@ZJay07 ZJay07 commented Mar 28, 2024

PR Description

Error thrown due to complex comparison, paddle does not support complex for greater equal not sure why the function was trying to do so, removing the comparison works, but not sure if it was essential to make a "complex acceptable" paddle.greater_equal

ref: https://www.paddlepaddle.org.cn/documentation/docs/en/2.2/api/paddle/greater_equal_en.html#greater-equal

Related Issue

Close #28700

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was based on our goal to superset the functions. So our backends are as comprehensive as possible. I think numpy support complex comparison so perhaps its trying to copy that.
image

Could you possibly check that out if it matches with np. Thank you very much :)

@ZJay07 ZJay07 requested a review from Ishticode April 1, 2024 19:42
@ZJay07
Copy link
Contributor Author

ZJay07 commented Apr 1, 2024

Similar fix to #28688

@Ishticode
Copy link
Contributor

Similar fix to #28688

Thanks. Similar to #28688 I would say supported dtypes can be extended here too like int8. But I can leave that for another PR. As you changes here don't touch the suppported dtypes decorators etc. As opposed to #28688.

Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ZJay07 for the effort put into this fix :)

@Ishticode Ishticode merged commit b04c444 into ivy-llc:main Apr 2, 2024
167 of 277 checks passed
@ZJay07 ZJay07 deleted the fixing-test-30 branch April 2, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Frontend Failing Test: paddle - comparison.numpy.greater_equal
3 participants