Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added the numpy.insert functionality #27944

Closed
wants to merge 2 commits into from

Conversation

arthurW1935
Copy link

PR Description

This PR contains the frontend implementation of numpy.insert function.

Related Issue

Closes #27415

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉
Join the conversation in our Discord.

For every PR opened, we run unit tests and comment the results in the PR to ensure the functionality remains intact.
Please make sure they are passing. 💪

If you want to check them from the action runners, you can open the display_test_results job. 👀
It contains the following two sections:

  • Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
  • New Failures Introduced: This lists the tests that fail on this PR.

Keep in mind that we will assign an engineer for this task and they will look at it based on the workload that they have, kindly be patient 😄.

@ivy-leaves ivy-leaves added NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist Ivy Functional API labels Jan 17, 2024
@arthurW1935 arthurW1935 changed the title added the numpy.insert functionality feat: added the numpy.insert functionality Jan 17, 2024
@soma2000-lang
Copy link
Contributor

@arthurW1935 kindly write tests for the function added.

@soma2000-lang soma2000-lang self-assigned this Jan 30, 2024
@Ishticode
Copy link
Contributor

Closing this due to inactivity for over 2 months after changes were requested. Please feel free to reopen if you would like to continue working on this. Thanks :)

@Ishticode Ishticode closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ivy Functional API NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numpy.insert
6 participants