Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added numpy gradient function and its test #27778

Closed
wants to merge 8 commits into from

Conversation

alvin-98
Copy link
Contributor

PR Description

Added numpy gradient frontend function and its test

Related Issue

Closes #27737

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

The code is failing for paddle alone and for examples involving nan in the output. I'm working on trying to fix it but any help would be great! Thanks :)
image

This is the failure message from hypothesis -
image

image

Socials

@ivy-leaves ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Dec 20, 2023
@MuhammadNizamani
Copy link
Contributor

Try to run the test of the function ivy.gradient and check if the the paddle test fails for that parent function.
@alvin-98

@NiteshK84
Copy link
Contributor

Hi @alvin-98, do you have any update on this PR,
let me know if you need any help.

@alvin-98
Copy link
Contributor Author

alvin-98 commented Dec 28, 2023

Hi @NiteshK84, I ran the test of the function ivy.gradient as per @MuhammadNizamani's suggestion above and found that all of its tests were failing, however, only the paddle test was failing in the case of test_numpy_gradient function.

@NiteshK84
Copy link
Contributor

NiteshK84 commented Jan 3, 2024

Try to run the test of the function ivy.gradient and check if the the paddle test fails for that parent function. @alvin-98

Hi @alvin-98,
i have reviewed your PR, there is some problem with the ivy.gradient core function itself,
so until that is resolved, you can pick another issue and start working on it.

@NiteshK84
Copy link
Contributor

Hi @alvin-98,
I looked in to this issue a little more and got to know that you can use ivy.execute_with_gradients instead of ivy.gradient, it might work.
once done, you can let me know.
Thanks

@Ishticode
Copy link
Contributor

Ishticode commented Apr 2, 2024

Closing this due to inactivity for nearly 3 months. Please feel free to reopen if you would like to continue working on this. Thanks for the efforts :)

@Ishticode Ishticode closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numpy.gradient
8 participants