socket.pyx::connect() has a pointless while(1) loop

[samrushing]

Notice that there's no way of running the 'loop' more than once. Can anyone explain this?
I think the loop should just be removed, unlike read/write, you can't call connect() more than once if it blocks.

[halayli]

If we don't want to handle errno == EAGAIN then I don't see the need for it.

[ehuss]

Without the history, we could only guess what originally happened. It doesn't look like it handles EAGAIN properly (EAGAIN==EWOULDBLOCK). According to the man page this would only happen if the system runs out of auto-assign ports, in which case it should probably just raise oserror. I would just remove the check for EWOULDBLOCK and remove the while 1, leaving the check for EINPROGRESS as-is.