Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 7.0 #1222

Open
3 of 6 tasks
blink1073 opened this issue Mar 22, 2024 · 7 comments
Open
3 of 6 tasks

Release 7.0 #1222

blink1073 opened this issue Mar 22, 2024 · 7 comments
Assignees

Comments

@blink1073
Copy link
Contributor

blink1073 commented Mar 22, 2024

main is currently targeting ipykernel 7.0, with support for AnyIO.

We have to address the following before releasing:

  • inprocess tests are failing after Replace Tornado with AnyIO #1079, and are currently skipped
  • jupyter_client tests are failing. We will need to make a release that supports both ipykernel 6.0 and 7.0
  • qtconsoletests are failing. We will need to make a release that supports both ipykernel 6.0 and 7.0, or a release that pins to (<7.0).
  • Minimum Version tests are failing. We will need to update minimum versions to get that passing.
  • Pin to (<7.0) in metakernel for now - Add compatibility with IPyKernel 7.0 Calysto/metakernel#275
  • Add migration documentation (it might be helpful to write this while updating Metakernel)
@blink1073
Copy link
Contributor Author

cc @davidbrochart @ccordoba12

@blink1073
Copy link
Contributor Author

cc @ianthomas23

@ccordoba12
Copy link
Member

ccordoba12 commented Mar 22, 2024

inprocess tests are failing after #1079, and are currently skipped

Perhaps this is the reason why Qtconsole tests are failing because it supports an in-process frontend.

spyder_kernels tests are failing. We will need to make a release that supports both ipykernel 6.0 and 7.0

We have an upper constraint on IPykernel (< 7.0), so we'll only need to add support for ipykernel 7.0 in a minor Spyder-kernels release.

@blink1073
Copy link
Contributor Author

Perhaps this is the reason why Qtconsole tests are failing because it supports an in-process frontend.

Good to know, thanks. If not, we can pin Qtconsole to (<7.0) as well.

For jupyter_client, I think it is a matter of updating the tests only, which use classes from ipykernel.

@davidbrochart
Copy link
Collaborator

I started looking at the jupyter-client tests, test_start_sequence_kernels at least will be fixed by agronholm/anyio#714.

@blink1073
Copy link
Contributor Author

I'm stepping down from maintenance, so I won't be able to complete this release.

@Carreau Carreau self-assigned this Oct 14, 2024
@Carreau
Copy link
Member

Carreau commented Oct 14, 2024

Listing some of the changes:

  • start_kernel is now async, and need to be awaited in a couple of places. Both in this repository and qtconsole.
  • we coudl add --enable-error-code unused-awaitable to mypy.
  • It looks like ipykernel test infratructure set ._is_test in conftext.py, which is not used in qtconsole. Not sure how to do that.
  • I'm wondering if some of the newest subshell things did not break some assumptions. They seem to make start_kernel blocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants