[skip changelog]Fix issue in ResourceManager and nopfsPlugin about repo path

[fengzie]

For ResourceManager and nopfsPlugin, we need pass the Repo path for use, instead of getting from config.PathRoot(), which might not be the right one.

This will also fixes issue #10407 .

[lidel]

Triage notes:

• we want to fix denylist support first, we plan to look into it in 0.31 (Release 0.31 #10499), then we will revisit this PR
  • understand why we need it, and was not a problem before

[lidel]

@fengzie just to be sure this is triage properly, mind elaborating what you mean by "we need pass the Repo path for use, instead of getting from config.PathRoot(), which might not be the right one."?

What would be example of state or use case where config.PathRoot() is "not be the right one"?

[lidel]

What about in-memory or remote / virtual repos?

my understanding is that reading path from config makes more sense, because we know that the config file in filesystem somewhere, and resourcemanager or nopfs files could live there.

[fengzie]

Currently only FSRepo is provided. For the other kind of repo implementations, there should be design to be compatible with resourcemanager or nopfs.

kubo/repo/fsrepo/fsrepo.go

Line 366 in ce23fc7

func (r *FSRepo) Path() string {

[fengzie]

@fengzie just to be sure this is triage properly, mind elaborating what you mean by "we need pass the Repo path for use, instead of getting from config.PathRoot(), which might not be the right one."?

What would be example of state or use case where config.PathRoot() is "not be the right one"?

Hi @lidel , for config.PathRoot(), it gets the value from environment variable firstly, if empty it uses the default DefaultPathRoot. However, when creating an IPFS instance, user can specify the repo path instead of the default one.

If user create multiple instances through the SDK, then there might be issue.

kubo/config/config.go

Line 57 in ce23fc7

func PathRoot() (string, error) {