Ignore non-IPFS content paths in DNSLink records

[martinheidegger]

Version:

js-ipfs version: 0.5.4-511147bedd51be3151de44a90fefe9425bfbcd50
interface-ipfs-core version: ^0.144.2
ipfs-http-client version: undefined
Repo version: 10
System version: x64/darwin
Node.js version: v16.1.0
Commit: 511147bedd51be3151de44a90fefe9425bfbcd50

Platform

Darwin xxx 20.4.0 Darwin Kernel Version 20.4.0

• Subsystem:
  dns-nodejs

Severity:

Low - An optional functionality does not work.

Description:

dns-nodejs returns currently the first dnslink= txt entry that can be found for a given domain, independent from the given protocol prefix, which prevents other decentralized protocols from using dnslink. It would probably be good for dnslink-nodejs to look for the ipfs dnslink entry only.

Note: I also opened related issues on go-dnslink#14 and js-dnslink#5.

Steps to reproduce the error:

Create a domain with a dnslink=/hyper/... entry and dnslink=/ipfs option and see how (depending on the order returned by the dns function!) how it will not consistently return the correct entry.

[lidel]

👍

The gist here is to ignore DNSLink records with content paths with prefix other than /ipfs/ and /ipns/.
This way other systems can use publish their own DNSLink records without impacting resolution in js-ipfs.

We should also interpret /dnslink as /ipns and try to resolve it to the final form.

[SgtPooki]

js-ipfs is being deprecated in favor of Helia. You can ipfs/js-ipfs#4336 and read the migration guide.

Please feel to reopen with any comments by 2023-06-02. We will do a final pass on reopened issues afterward (see ipfs/js-ipfs#4336).

Assigning to @achingbrain to answer whether this issue is already resolved in Helia, or if this issue needs to be migrated to that repo!

[SgtPooki]

I believe this is fixed by #466?

[achingbrain]

Yes, #466 will close this